From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Wed, 9 Sep 2015 21:21:01 +0100 Message-ID: <20150909202100.GA25704@zion.uk.xensource.com> References: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com> <1441818218-5414-4-git-send-email-wei.liu2@citrix.com> <55F07F2C.6050803@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZZlrd-0001rx-Ad for xen-devel@lists.xenproject.org; Wed, 09 Sep 2015 20:21:05 +0000 Content-Disposition: inline In-Reply-To: <55F07F2C.6050803@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ian Jackson , Xen-devel , Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Wed, Sep 09, 2015 at 07:49:16PM +0100, Andrew Cooper wrote: > On 09/09/15 18:03, Wei Liu wrote: > >This is due to migration v2 frame record doesn't contain node > >information. > > This isn't a migration v2 bug, and it was similarly non-functional with > legacy migration. It was yet another oversight with the vNUMA work. > Indeed. I mentioned that in v1 patch but dropped it in v2 -- legacy migration is gone anyway. > Isn't this information available in the domain configuration for the domain > sent in the xl header? (That layer violation also need removing). > Yes. But restoring a guest takes a path different from guest creation to populate guest pages. > Finally, your phrasing is somewhat unclear. I would recommend "The > migration stream does not preserve node information" as a clearer > alternative. > Fine by me. Wei. > ~Andrew