From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/p2m: fix mismatched unlock
Date: Mon, 14 Sep 2015 09:45:02 +0100 [thread overview]
Message-ID: <20150914084502.GA2728@zion.uk.xensource.com> (raw)
In-Reply-To: <55F68FBB02000078000A268C@prv-mh.provo.novell.com>
On Mon, Sep 14, 2015 at 01:13:31AM -0600, Jan Beulich wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
> omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
> if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
> {
> - p2m_unlock(p2m);
> + gfn_unlock(p2m, gfn, 0);
> domain_crash(d);
> return -ENOENT;
> }
>
>
>
> x86/p2m: fix mismatched unlock
>
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
> omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
> if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
> {
> - p2m_unlock(p2m);
> + gfn_unlock(p2m, gfn, 0);
> domain_crash(d);
> return -ENOENT;
> }
next prev parent reply other threads:[~2015-09-14 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 7:13 [PATCH] x86/p2m: fix mismatched unlock Jan Beulich
2015-09-14 8:45 ` Wei Liu [this message]
2015-09-14 9:49 ` Andrew Cooper
2015-09-14 10:49 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914084502.GA2728@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).