Re: [PATCH v3 3/4] tools: add tools support for Intel CDP

[Chao Peng <chao.p.peng@linux.intel.com>]

On Mon, Sep 14, 2015 at 11:27:06AM +0800, He Chen wrote:
> This is the xl/xc changes to support Intel Code/Data Prioritization.
> CAT xl commands to set/get CBMs are extended to support CDP.
> 
> Signed-off-by: He Chen <he.chen@linux.intel.com>
> ---
>  #define LIBXL_HAVE_PSR_CAT 1
> +
? And you still need to broadcast the feature, just like what you have done
in v2 (e.g. to define LIBXL_HAVE_PSR_CDP).

>  #endif
>  
>  /*
> diff --git a/tools/libxl/libxl_psr.c b/tools/libxl/libxl_psr.c
> index 3378239..140af4d 100644
> --- a/tools/libxl/libxl_psr.c
> +++ b/tools/libxl/libxl_psr.c
> @@ -297,6 +297,7 @@ int libxl_psr_cat_set_cbm(libxl_ctx *ctx, uint32_t domid,
>      GC_INIT(ctx);
>      int rc;
>      int socketid, nr_sockets;
> +    libxl_psr_cat_info *info;
>  
>      rc = libxl__count_physical_sockets(gc, &nr_sockets);
>      if (rc) {
> @@ -304,6 +305,22 @@ int libxl_psr_cat_set_cbm(libxl_ctx *ctx, uint32_t domid,
>          goto out;
>      }
>  
> +    rc = libxl_psr_cat_get_l3_info(ctx, &info, &nr_sockets);
> +    if (rc) {
> +        LOGE(ERROR, "Failed to get cat info");
> +        goto out;
> +    }
> +
> +    if (!info->cdp_enabled &&
> +       (type == LIBXL_PSR_CBM_TYPE_L3_CODE ||

Does this align up correctly?

Chao