From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount Date: Tue, 15 Sep 2015 09:58:14 -0400 Message-ID: <20150915135814.GJ9134@l.oracle.com> References: <1418988333-5404-1-git-send-email-olaf@aepfle.de> <1418988333-5404-2-git-send-email-olaf@aepfle.de> <20150911063100.GA9276@aepfle.de> <55F6F629.3040409@citrix.com> <20150914183357.GA13426@aepfle.de> <20150915124856.GA12153@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Olaf Hering , Wei Liu , Ian Campbell , Stefano Stabellini , "Luis R. Rodriguez" , Ian Jackson , George Dunlap , "xen-devel@lists.xen.org" , M A Young , Anthony PERARD List-Id: xen-devel@lists.xenproject.org On Tue, Sep 15, 2015 at 01:55:15PM +0100, George Dunlap wrote: > On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering wrote: > > On Tue, Sep 15, George Dunlap wrote: > > > >> It's very reasonable for you to expect it to be fixed on non-SELinux > >> systems. But what you did is fix it for non-SELinux systems by simply > >> breaking it on SELinux systems -- that's not at all reasonable. > > > > Konrad did some testing at that time and said 4.5 was ok. > > Why is 4.6 broken now? > > OK -- I see that he committed it, but I didn't see him say that he had > tested this particular patch. It would be interesting to find out why > it worked for him. It just worked out of the box when I installed an source build of the Xen on a virgin Fedora box. I am not sure how it worked if SELinux ended up being disabled! > > -George