xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add missing license and copyright statements to public interface headers.
@ 2015-09-17 11:53 Mike Belopuhov
  2015-09-17 18:52 ` Konrad Rzeszutek Wilk
  2015-09-18  8:44 ` Ian Campbell
  0 siblings, 2 replies; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-17 11:53 UTC (permalink / raw)
  To: xen-devel; +Cc: Boris Ostrovsky, Ian Campbell

Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
---
 xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
 xen/include/public/hvm/e820.h           |  3 ++-
 xen/include/public/hvm/hvm_info_table.h |  2 ++
 xen/include/public/hvm/hvm_op.h         |  2 ++
 xen/include/public/hvm/hvm_xs_strings.h |  2 ++
 xen/include/public/hvm/params.h         |  2 ++
 xen/include/public/io/protocols.h       |  2 ++
 xen/include/public/physdev.h            |  2 ++
 xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
 9 files changed, 58 insertions(+), 1 deletion(-)

diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch-x86/pmu.h
index 1a53888..cb05121 100644
--- xen/include/public/arch-x86/pmu.h
+++ xen/include/public/arch-x86/pmu.h
@@ -1,5 +1,27 @@
+/*
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
+ */
+
 #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
 #define __XEN_PUBLIC_ARCH_X86_PMU_H__
 
 /* x86-specific PMU definitions */
 
diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
index 5bdc227..6c58a37 100644
--- xen/include/public/hvm/e820.h
+++ xen/include/public/hvm/e820.h
@@ -1,6 +1,5 @@
-
 /*
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to
  * deal in the Software without restriction, including without limitation the
  * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
@@ -15,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_E820_H__
 #define __XEN_PUBLIC_HVM_E820_H__
 
diff --git xen/include/public/hvm/hvm_info_table.h xen/include/public/hvm/hvm_info_table.h
index 36085fa..9e3f807 100644
--- xen/include/public/hvm/hvm_info_table.h
+++ xen/include/public/hvm/hvm_info_table.h
@@ -18,10 +18,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
 #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
 
diff --git xen/include/public/hvm/hvm_op.h xen/include/public/hvm/hvm_op.h
index 014546a..1606185 100644
--- xen/include/public/hvm/hvm_op.h
+++ xen/include/public/hvm/hvm_op.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2007, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
 #define __XEN_PUBLIC_HVM_HVM_OP_H__
 
diff --git xen/include/public/hvm/hvm_xs_strings.h xen/include/public/hvm/hvm_xs_strings.h
index 8aec935..146b0b0 100644
--- xen/include/public/hvm/hvm_xs_strings.h
+++ xen/include/public/hvm/hvm_xs_strings.h
@@ -18,10 +18,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2013, Citrix Systems
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
 #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
 
diff --git xen/include/public/hvm/params.h xen/include/public/hvm/params.h
index 147d9b8..356dfd3 100644
--- xen/include/public/hvm/params.h
+++ xen/include/public/hvm/params.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2007, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
 #define __XEN_PUBLIC_HVM_PARAMS_H__
 
diff --git xen/include/public/io/protocols.h xen/include/public/io/protocols.h
index 80b196b..40a9b30 100644
--- xen/include/public/io/protocols.h
+++ xen/include/public/io/protocols.h
@@ -16,10 +16,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2008, Keir Fraser
  */
 
 #ifndef __XEN_PROTOCOLS_H__
 #define __XEN_PROTOCOLS_H__
 
diff --git xen/include/public/physdev.h xen/include/public/physdev.h
index c9be6de..0e54635 100644
--- xen/include/public/physdev.h
+++ xen/include/public/physdev.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_PHYSDEV_H__
 #define __XEN_PUBLIC_PHYSDEV_H__
 
diff --git xen/include/public/pmu.h xen/include/public/pmu.h
index 1149678..8d16b30 100644
--- xen/include/public/pmu.h
+++ xen/include/public/pmu.h
@@ -1,5 +1,27 @@
+/*
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
+ */
+
 #ifndef __XEN_PUBLIC_PMU_H__
 #define __XEN_PUBLIC_PMU_H__
 
 #include "xen.h"
 #if defined(__i386__) || defined(__x86_64__)
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-17 11:53 [PATCH] Add missing license and copyright statements to public interface headers Mike Belopuhov
@ 2015-09-17 18:52 ` Konrad Rzeszutek Wilk
  2015-09-18  8:44 ` Ian Campbell
  1 sibling, 0 replies; 18+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-09-17 18:52 UTC (permalink / raw)
  To: Mike Belopuhov; +Cc: Boris Ostrovsky, Ian Campbell, xen-devel

On Thu, Sep 17, 2015 at 01:53:09PM +0200, Mike Belopuhov wrote:
> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>

I can't speak for Keir, but I think the Copyright for Oracle needs
to be:

> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.

Copyright (c) 2015 Oracle Corp.

Author: Boris Ostrovsky

.. and so on.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-17 11:53 [PATCH] Add missing license and copyright statements to public interface headers Mike Belopuhov
  2015-09-17 18:52 ` Konrad Rzeszutek Wilk
@ 2015-09-18  8:44 ` Ian Campbell
  2015-09-18 12:00   ` Boris Ostrovsky
  1 sibling, 1 reply; 18+ messages in thread
From: Ian Campbell @ 2015-09-18  8:44 UTC (permalink / raw)
  To: Mike Belopuhov, xen-devel; +Cc: Boris Ostrovsky, keir

On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:

A few words here about the methodology you used to determine the names to
use would be useful to people looking back on this stuff in the future.

Also it would be sensible to CC everyone whose name you are adding. I've
added Keir since you already Ccd Boris and I didn't see any other names
after a quick glance.

Ian.

> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
> ---
>  xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
>  xen/include/public/hvm/e820.h           |  3 ++-
>  xen/include/public/hvm/hvm_info_table.h |  2 ++
>  xen/include/public/hvm/hvm_op.h         |  2 ++
>  xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>  xen/include/public/hvm/params.h         |  2 ++
>  xen/include/public/io/protocols.h       |  2 ++
>  xen/include/public/physdev.h            |  2 ++
>  xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
>  9 files changed, 58 insertions(+), 1 deletion(-)
> 
> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
> -x86/pmu.h
> index 1a53888..cb05121 100644
> --- xen/include/public/arch-x86/pmu.h
> +++ xen/include/public/arch-x86/pmu.h
> @@ -1,5 +1,27 @@
> +/*
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to
> + * deal in the Software without restriction, including without
> limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> + * sell copies of the Software, and to permit persons to whom the
> Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
> + */
> +
>  #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>  #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>  
>  /* x86-specific PMU definitions */
>  
> diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
> index 5bdc227..6c58a37 100644
> --- xen/include/public/hvm/e820.h
> +++ xen/include/public/hvm/e820.h
> @@ -1,6 +1,5 @@
> -
>  /*
>   * Permission is hereby granted, free of charge, to any person obtaining
> a copy
>   * of this software and associated documentation files (the "Software"),
> to
>   * deal in the Software without restriction, including without
> limitation the
>   * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> @@ -15,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_E820_H__
>  #define __XEN_PUBLIC_HVM_E820_H__
>  
> diff --git xen/include/public/hvm/hvm_info_table.h
> xen/include/public/hvm/hvm_info_table.h
> index 36085fa..9e3f807 100644
> --- xen/include/public/hvm/hvm_info_table.h
> +++ xen/include/public/hvm/hvm_info_table.h
> @@ -18,10 +18,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>  #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>  
> diff --git xen/include/public/hvm/hvm_op.h
> xen/include/public/hvm/hvm_op.h
> index 014546a..1606185 100644
> --- xen/include/public/hvm/hvm_op.h
> +++ xen/include/public/hvm/hvm_op.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2007, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>  #define __XEN_PUBLIC_HVM_HVM_OP_H__
>  
> diff --git xen/include/public/hvm/hvm_xs_strings.h
> xen/include/public/hvm/hvm_xs_strings.h
> index 8aec935..146b0b0 100644
> --- xen/include/public/hvm/hvm_xs_strings.h
> +++ xen/include/public/hvm/hvm_xs_strings.h
> @@ -18,10 +18,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2013, Citrix Systems
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>  #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>  
> diff --git xen/include/public/hvm/params.h
> xen/include/public/hvm/params.h
> index 147d9b8..356dfd3 100644
> --- xen/include/public/hvm/params.h
> +++ xen/include/public/hvm/params.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2007, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>  #define __XEN_PUBLIC_HVM_PARAMS_H__
>  
> diff --git xen/include/public/io/protocols.h
> xen/include/public/io/protocols.h
> index 80b196b..40a9b30 100644
> --- xen/include/public/io/protocols.h
> +++ xen/include/public/io/protocols.h
> @@ -16,10 +16,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2008, Keir Fraser
>   */
>  
>  #ifndef __XEN_PROTOCOLS_H__
>  #define __XEN_PROTOCOLS_H__
>  
> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
> index c9be6de..0e54635 100644
> --- xen/include/public/physdev.h
> +++ xen/include/public/physdev.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_PHYSDEV_H__
>  #define __XEN_PUBLIC_PHYSDEV_H__
>  
> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
> index 1149678..8d16b30 100644
> --- xen/include/public/pmu.h
> +++ xen/include/public/pmu.h
> @@ -1,5 +1,27 @@
> +/*
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to
> + * deal in the Software without restriction, including without
> limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> + * sell copies of the Software, and to permit persons to whom the
> Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
> + */
> +
>  #ifndef __XEN_PUBLIC_PMU_H__
>  #define __XEN_PUBLIC_PMU_H__
>  
>  #include "xen.h"
>  #if defined(__i386__) || defined(__x86_64__)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-18  8:44 ` Ian Campbell
@ 2015-09-18 12:00   ` Boris Ostrovsky
  2015-09-18 14:13     ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 18+ messages in thread
From: Boris Ostrovsky @ 2015-09-18 12:00 UTC (permalink / raw)
  To: Ian Campbell, Mike Belopuhov, xen-devel; +Cc: keir



On 09/18/2015 04:44 AM, Ian Campbell wrote:
> On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
>
> A few words here about the methodology you used to determine the names to
> use would be useful to people looking back on this stuff in the future.
>
> Also it would be sensible to CC everyone whose name you are adding. I've
> added Keir since you already Ccd Boris and I didn't see any other names
> after a quick glance.

For changes that include my name (pmu files)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Not sure about format --- files in public directory largely use the same 
format as what Mike is suggesting here but most of newer files do what 
Konrad said (i.e. "Author" on a separate line).

We will also want to apply similar patch to Linux tree (once this is 
done). Mike, do you mind doing it too?

-boris

>
> Ian.
>
>> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
>> ---
>>   xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
>>   xen/include/public/hvm/e820.h           |  3 ++-
>>   xen/include/public/hvm/hvm_info_table.h |  2 ++
>>   xen/include/public/hvm/hvm_op.h         |  2 ++
>>   xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>>   xen/include/public/hvm/params.h         |  2 ++
>>   xen/include/public/io/protocols.h       |  2 ++
>>   xen/include/public/physdev.h            |  2 ++
>>   xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
>>   9 files changed, 58 insertions(+), 1 deletion(-)
>>
>> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
>> -x86/pmu.h
>> index 1a53888..cb05121 100644
>> --- xen/include/public/arch-x86/pmu.h
>> +++ xen/include/public/arch-x86/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   
>>   /* x86-specific PMU definitions */
>>   
>> diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
>> index 5bdc227..6c58a37 100644
>> --- xen/include/public/hvm/e820.h
>> +++ xen/include/public/hvm/e820.h
>> @@ -1,6 +1,5 @@
>> -
>>   /*
>>    * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>>    * of this software and associated documentation files (the "Software"),
>> to
>>    * deal in the Software without restriction, including without
>> limitation the
>>    * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> @@ -15,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_E820_H__
>>   #define __XEN_PUBLIC_HVM_E820_H__
>>   
>> diff --git xen/include/public/hvm/hvm_info_table.h
>> xen/include/public/hvm/hvm_info_table.h
>> index 36085fa..9e3f807 100644
>> --- xen/include/public/hvm/hvm_info_table.h
>> +++ xen/include/public/hvm/hvm_info_table.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   
>> diff --git xen/include/public/hvm/hvm_op.h
>> xen/include/public/hvm/hvm_op.h
>> index 014546a..1606185 100644
>> --- xen/include/public/hvm/hvm_op.h
>> +++ xen/include/public/hvm/hvm_op.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>>   #define __XEN_PUBLIC_HVM_HVM_OP_H__
>>   
>> diff --git xen/include/public/hvm/hvm_xs_strings.h
>> xen/include/public/hvm/hvm_xs_strings.h
>> index 8aec935..146b0b0 100644
>> --- xen/include/public/hvm/hvm_xs_strings.h
>> +++ xen/include/public/hvm/hvm_xs_strings.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2013, Citrix Systems
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   
>> diff --git xen/include/public/hvm/params.h
>> xen/include/public/hvm/params.h
>> index 147d9b8..356dfd3 100644
>> --- xen/include/public/hvm/params.h
>> +++ xen/include/public/hvm/params.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>>   #define __XEN_PUBLIC_HVM_PARAMS_H__
>>   
>> diff --git xen/include/public/io/protocols.h
>> xen/include/public/io/protocols.h
>> index 80b196b..40a9b30 100644
>> --- xen/include/public/io/protocols.h
>> +++ xen/include/public/io/protocols.h
>> @@ -16,10 +16,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2008, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PROTOCOLS_H__
>>   #define __XEN_PROTOCOLS_H__
>>   
>> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
>> index c9be6de..0e54635 100644
>> --- xen/include/public/physdev.h
>> +++ xen/include/public/physdev.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_PHYSDEV_H__
>>   #define __XEN_PUBLIC_PHYSDEV_H__
>>   
>> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
>> index 1149678..8d16b30 100644
>> --- xen/include/public/pmu.h
>> +++ xen/include/public/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_PMU_H__
>>   #define __XEN_PUBLIC_PMU_H__
>>   
>>   #include "xen.h"
>>   #if defined(__i386__) || defined(__x86_64__)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-18 12:00   ` Boris Ostrovsky
@ 2015-09-18 14:13     ` Konrad Rzeszutek Wilk
  2015-09-22 11:42       ` Mike Belopuhov
  0 siblings, 1 reply; 18+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-09-18 14:13 UTC (permalink / raw)
  To: Boris Ostrovsky; +Cc: Mike Belopuhov, keir, Ian Campbell, xen-devel

On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote:
> 
> 
> On 09/18/2015 04:44 AM, Ian Campbell wrote:
> >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
> >
> >A few words here about the methodology you used to determine the names to
> >use would be useful to people looking back on this stuff in the future.
> >
> >Also it would be sensible to CC everyone whose name you are adding. I've
> >added Keir since you already Ccd Boris and I didn't see any other names
> >after a quick glance.
> 
> For changes that include my name (pmu files)
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Nack. Sorry Boris.

Let me send an email to legal to make sure I am not spouting
nonsense. But in the meantime my understanding is that:

 Copyright (c) 2015 X,Y

means that the copyright (ownership of intellectual property)
is owned by both X and Y.

However we (Boris, and me) both signed this fancy document saying
that any work we do is owned by Oracle. It is OK to state
the authorship, but the ownership is Oracle's.

If it was

 Copyright (c) 2015 X

 Author: Y

Then that is OK.
> 
> Not sure about format --- files in public directory largely use the same
> format as what Mike is suggesting here but most of newer files do what
> Konrad said (i.e. "Author" on a separate line).
> 
> We will also want to apply similar patch to Linux tree (once this is done).
> Mike, do you mind doing it too?
> 
> -boris
> 
> >
> >Ian.
> >
> >>Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
> >>---
> >>  xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
> >>  xen/include/public/hvm/e820.h           |  3 ++-
> >>  xen/include/public/hvm/hvm_info_table.h |  2 ++
> >>  xen/include/public/hvm/hvm_op.h         |  2 ++
> >>  xen/include/public/hvm/hvm_xs_strings.h |  2 ++
> >>  xen/include/public/hvm/params.h         |  2 ++
> >>  xen/include/public/io/protocols.h       |  2 ++
> >>  xen/include/public/physdev.h            |  2 ++
> >>  xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
> >>  9 files changed, 58 insertions(+), 1 deletion(-)
> >>
> >>diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
> >>-x86/pmu.h
> >>index 1a53888..cb05121 100644
> >>--- xen/include/public/arch-x86/pmu.h
> >>+++ xen/include/public/arch-x86/pmu.h
> >>@@ -1,5 +1,27 @@
> >>+/*
> >>+ * Permission is hereby granted, free of charge, to any person obtaining
> >>a copy
> >>+ * of this software and associated documentation files (the "Software"),
> >>to
> >>+ * deal in the Software without restriction, including without
> >>limitation the
> >>+ * rights to use, copy, modify, merge, publish, distribute, sublicense,
> >>and/or
> >>+ * sell copies of the Software, and to permit persons to whom the
> >>Software is
> >>+ * furnished to do so, subject to the following conditions:
> >>+ *
> >>+ * The above copyright notice and this permission notice shall be
> >>included in
> >>+ * all copies or substantial portions of the Software.
> >>+ *
> >>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >>EXPRESS OR
> >>+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >>MERCHANTABILITY,
> >>+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>+ * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
> >>+ */
> >>+
> >>  #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
> >>  #define __XEN_PUBLIC_ARCH_X86_PMU_H__
> >>  /* x86-specific PMU definitions */
> >>diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
> >>index 5bdc227..6c58a37 100644
> >>--- xen/include/public/hvm/e820.h
> >>+++ xen/include/public/hvm/e820.h
> >>@@ -1,6 +1,5 @@
> >>-
> >>  /*
> >>   * Permission is hereby granted, free of charge, to any person obtaining
> >>a copy
> >>   * of this software and associated documentation files (the "Software"),
> >>to
> >>   * deal in the Software without restriction, including without
> >>limitation the
> >>   * rights to use, copy, modify, merge, publish, distribute, sublicense,
> >>and/or
> >>@@ -15,10 +14,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2006, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PUBLIC_HVM_E820_H__
> >>  #define __XEN_PUBLIC_HVM_E820_H__
> >>diff --git xen/include/public/hvm/hvm_info_table.h
> >>xen/include/public/hvm/hvm_info_table.h
> >>index 36085fa..9e3f807 100644
> >>--- xen/include/public/hvm/hvm_info_table.h
> >>+++ xen/include/public/hvm/hvm_info_table.h
> >>@@ -18,10 +18,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2006, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
> >>  #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
> >>diff --git xen/include/public/hvm/hvm_op.h
> >>xen/include/public/hvm/hvm_op.h
> >>index 014546a..1606185 100644
> >>--- xen/include/public/hvm/hvm_op.h
> >>+++ xen/include/public/hvm/hvm_op.h
> >>@@ -14,10 +14,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2007, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
> >>  #define __XEN_PUBLIC_HVM_HVM_OP_H__
> >>diff --git xen/include/public/hvm/hvm_xs_strings.h
> >>xen/include/public/hvm/hvm_xs_strings.h
> >>index 8aec935..146b0b0 100644
> >>--- xen/include/public/hvm/hvm_xs_strings.h
> >>+++ xen/include/public/hvm/hvm_xs_strings.h
> >>@@ -18,10 +18,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2013, Citrix Systems
> >>   */
> >>  #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
> >>  #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
> >>diff --git xen/include/public/hvm/params.h
> >>xen/include/public/hvm/params.h
> >>index 147d9b8..356dfd3 100644
> >>--- xen/include/public/hvm/params.h
> >>+++ xen/include/public/hvm/params.h
> >>@@ -14,10 +14,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2007, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
> >>  #define __XEN_PUBLIC_HVM_PARAMS_H__
> >>diff --git xen/include/public/io/protocols.h
> >>xen/include/public/io/protocols.h
> >>index 80b196b..40a9b30 100644
> >>--- xen/include/public/io/protocols.h
> >>+++ xen/include/public/io/protocols.h
> >>@@ -16,10 +16,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2008, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PROTOCOLS_H__
> >>  #define __XEN_PROTOCOLS_H__
> >>diff --git xen/include/public/physdev.h xen/include/public/physdev.h
> >>index c9be6de..0e54635 100644
> >>--- xen/include/public/physdev.h
> >>+++ xen/include/public/physdev.h
> >>@@ -14,10 +14,12 @@
> >>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>   * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2006, Keir Fraser
> >>   */
> >>  #ifndef __XEN_PUBLIC_PHYSDEV_H__
> >>  #define __XEN_PUBLIC_PHYSDEV_H__
> >>diff --git xen/include/public/pmu.h xen/include/public/pmu.h
> >>index 1149678..8d16b30 100644
> >>--- xen/include/public/pmu.h
> >>+++ xen/include/public/pmu.h
> >>@@ -1,5 +1,27 @@
> >>+/*
> >>+ * Permission is hereby granted, free of charge, to any person obtaining
> >>a copy
> >>+ * of this software and associated documentation files (the "Software"),
> >>to
> >>+ * deal in the Software without restriction, including without
> >>limitation the
> >>+ * rights to use, copy, modify, merge, publish, distribute, sublicense,
> >>and/or
> >>+ * sell copies of the Software, and to permit persons to whom the
> >>Software is
> >>+ * furnished to do so, subject to the following conditions:
> >>+ *
> >>+ * The above copyright notice and this permission notice shall be
> >>included in
> >>+ * all copies or substantial portions of the Software.
> >>+ *
> >>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >>EXPRESS OR
> >>+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >>MERCHANTABILITY,
> >>+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >>SHALL THE
> >>+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> >>OTHER
> >>+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >>ARISING
> >>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>+ * DEALINGS IN THE SOFTWARE.
> >>+ *
> >>+ * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
> >>+ */
> >>+
> >>  #ifndef __XEN_PUBLIC_PMU_H__
> >>  #define __XEN_PUBLIC_PMU_H__
> >>  #include "xen.h"
> >>  #if defined(__i386__) || defined(__x86_64__)
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-18 14:13     ` Konrad Rzeszutek Wilk
@ 2015-09-22 11:42       ` Mike Belopuhov
  2015-09-22 13:00         ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-22 11:42 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk; +Cc: Boris Ostrovsky, keir, Ian Campbell, xen-devel

On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote:
> > 
> > 
> > On 09/18/2015 04:44 AM, Ian Campbell wrote:
> > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
> > >
> > >A few words here about the methodology you used to determine the names to
> > >use would be useful to people looking back on this stuff in the future.
> > >
> > >Also it would be sensible to CC everyone whose name you are adding. I've
> > >added Keir since you already Ccd Boris and I didn't see any other names
> > >after a quick glance.
> > 
> > For changes that include my name (pmu files)
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> Nack. Sorry Boris.
> 
> Let me send an email to legal to make sure I am not spouting
> nonsense. But in the meantime my understanding is that:
> 
>  Copyright (c) 2015 X,Y
> 
> means that the copyright (ownership of intellectual property)
> is owned by both X and Y.
> 
> However we (Boris, and me) both signed this fancy document saying
> that any work we do is owned by Oracle. It is OK to state
> the authorship, but the ownership is Oracle's.
> 
> If it was
> 
>  Copyright (c) 2015 X
> 
>  Author: Y
> 
> Then that is OK.

Hi Konrad,

Any luck getting this sorted out?

Regards,
Mike

> > 
> > Not sure about format --- files in public directory largely use the same
> > format as what Mike is suggesting here but most of newer files do what
> > Konrad said (i.e. "Author" on a separate line).
> > 
> > We will also want to apply similar patch to Linux tree (once this is done).
> > Mike, do you mind doing it too?
> > 
> > -boris
> > 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-22 11:42       ` Mike Belopuhov
@ 2015-09-22 13:00         ` Konrad Rzeszutek Wilk
  2015-09-22 13:58           ` Mike Belopuhov
  0 siblings, 1 reply; 18+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-09-22 13:00 UTC (permalink / raw)
  To: Mike Belopuhov; +Cc: Boris Ostrovsky, keir, Ian Campbell, xen-devel

On Tue, Sep 22, 2015 at 01:42:14PM +0200, Mike Belopuhov wrote:
> On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote:
> > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote:
> > > 
> > > 
> > > On 09/18/2015 04:44 AM, Ian Campbell wrote:
> > > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
> > > >
> > > >A few words here about the methodology you used to determine the names to
> > > >use would be useful to people looking back on this stuff in the future.
> > > >
> > > >Also it would be sensible to CC everyone whose name you are adding. I've
> > > >added Keir since you already Ccd Boris and I didn't see any other names
> > > >after a quick glance.
> > > 
> > > For changes that include my name (pmu files)
> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > 
> > Nack. Sorry Boris.
> > 
> > Let me send an email to legal to make sure I am not spouting
> > nonsense. But in the meantime my understanding is that:
> > 
> >  Copyright (c) 2015 X,Y
> > 
> > means that the copyright (ownership of intellectual property)
> > is owned by both X and Y.
> > 
> > However we (Boris, and me) both signed this fancy document saying
> > that any work we do is owned by Oracle. It is OK to state
> > the authorship, but the ownership is Oracle's.
> > 
> > If it was
> > 
> >  Copyright (c) 2015 X
> > 
> >  Author: Y
> > 
> > Then that is OK.
> 
> Hi Konrad,
> 
> Any luck getting this sorted out?


Yes.

Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.


And no authorship.
> 
> Regards,
> Mike
> 
> > > 
> > > Not sure about format --- files in public directory largely use the same
> > > format as what Mike is suggesting here but most of newer files do what
> > > Konrad said (i.e. "Author" on a separate line).
> > > 
> > > We will also want to apply similar patch to Linux tree (once this is done).
> > > Mike, do you mind doing it too?
> > > 
> > > -boris
> > > 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-22 13:00         ` Konrad Rzeszutek Wilk
@ 2015-09-22 13:58           ` Mike Belopuhov
  0 siblings, 0 replies; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-22 13:58 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk; +Cc: Boris Ostrovsky, keir, Ian Campbell, xen-devel

On Tue, Sep 22, 2015 at 09:00 -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Sep 22, 2015 at 01:42:14PM +0200, Mike Belopuhov wrote:
> > On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote:
> > > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote:
> > > > 
> > > > 
> > > > On 09/18/2015 04:44 AM, Ian Campbell wrote:
> > > > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
> > > > >
> > > > >A few words here about the methodology you used to determine the names to
> > > > >use would be useful to people looking back on this stuff in the future.
> > > > >
> > > > >Also it would be sensible to CC everyone whose name you are adding. I've
> > > > >added Keir since you already Ccd Boris and I didn't see any other names
> > > > >after a quick glance.
> > > > 
> > > > For changes that include my name (pmu files)
> > > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > > 
> > > Nack. Sorry Boris.
> > > 
> > > Let me send an email to legal to make sure I am not spouting
> > > nonsense. But in the meantime my understanding is that:
> > > 
> > >  Copyright (c) 2015 X,Y
> > > 
> > > means that the copyright (ownership of intellectual property)
> > > is owned by both X and Y.
> > > 
> > > However we (Boris, and me) both signed this fancy document saying
> > > that any work we do is owned by Oracle. It is OK to state
> > > the authorship, but the ownership is Oracle's.
> > > 
> > > If it was
> > > 
> > >  Copyright (c) 2015 X
> > > 
> > >  Author: Y
> > > 
> > > Then that is OK.
> > 
> > Hi Konrad,
> > 
> > Any luck getting this sorted out?
> 
> 
> Yes.
> 
> Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
> 
> 
> And no authorship.

Thank you very much for clearing this up!

> > 
> > Regards,
> > Mike
> > 
> > > > 
> > > > Not sure about format --- files in public directory largely use the same
> > > > format as what Mike is suggesting here but most of newer files do what
> > > > Konrad said (i.e. "Author" on a separate line).
> > > > 
> > > > We will also want to apply similar patch to Linux tree (once this is done).
> > > > Mike, do you mind doing it too?
> > > > 
> > > > -boris
> > > > 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] Add missing license and copyright statements to public interface headers.
@ 2015-09-22 14:02 Mike Belopuhov
  2015-09-24 10:45 ` Ian Campbell
  2015-09-25  7:12 ` Jan Beulich
  0 siblings, 2 replies; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-22 14:02 UTC (permalink / raw)
  To: xen-devel; +Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell

The copyright line indicates a person, a group of people and/or a company
granting rights stated in the license text and is a required part of the
license.

The year of the copyright is chosen to be the same as when the license has
been applied to the file or when the file has been created in case there
was no license.  It is possible to update or add additional years if major
changes have been done to the the file, but is generally not a requirement.

Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
---
 xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
 xen/include/public/hvm/e820.h           |  3 ++-
 xen/include/public/hvm/hvm_info_table.h |  2 ++
 xen/include/public/hvm/hvm_op.h         |  2 ++
 xen/include/public/hvm/hvm_xs_strings.h |  2 ++
 xen/include/public/hvm/params.h         |  2 ++
 xen/include/public/io/protocols.h       |  2 ++
 xen/include/public/physdev.h            |  2 ++
 xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
 9 files changed, 58 insertions(+), 1 deletion(-)

diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch-x86/pmu.h
index 1a53888..68ebf12 100644
--- xen/include/public/arch-x86/pmu.h
+++ xen/include/public/arch-x86/pmu.h
@@ -1,5 +1,27 @@
+/*
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
+ */
+
 #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
 #define __XEN_PUBLIC_ARCH_X86_PMU_H__
 
 /* x86-specific PMU definitions */
 
diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
index 5bdc227..6c58a37 100644
--- xen/include/public/hvm/e820.h
+++ xen/include/public/hvm/e820.h
@@ -1,6 +1,5 @@
-
 /*
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to
  * deal in the Software without restriction, including without limitation the
  * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
@@ -15,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_E820_H__
 #define __XEN_PUBLIC_HVM_E820_H__
 
diff --git xen/include/public/hvm/hvm_info_table.h xen/include/public/hvm/hvm_info_table.h
index 36085fa..9e3f807 100644
--- xen/include/public/hvm/hvm_info_table.h
+++ xen/include/public/hvm/hvm_info_table.h
@@ -18,10 +18,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
 #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
 
diff --git xen/include/public/hvm/hvm_op.h xen/include/public/hvm/hvm_op.h
index 014546a..1606185 100644
--- xen/include/public/hvm/hvm_op.h
+++ xen/include/public/hvm/hvm_op.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2007, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
 #define __XEN_PUBLIC_HVM_HVM_OP_H__
 
diff --git xen/include/public/hvm/hvm_xs_strings.h xen/include/public/hvm/hvm_xs_strings.h
index 8aec935..146b0b0 100644
--- xen/include/public/hvm/hvm_xs_strings.h
+++ xen/include/public/hvm/hvm_xs_strings.h
@@ -18,10 +18,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2013, Citrix Systems
  */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
 #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
 
diff --git xen/include/public/hvm/params.h xen/include/public/hvm/params.h
index 147d9b8..356dfd3 100644
--- xen/include/public/hvm/params.h
+++ xen/include/public/hvm/params.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2007, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
 #define __XEN_PUBLIC_HVM_PARAMS_H__
 
diff --git xen/include/public/io/protocols.h xen/include/public/io/protocols.h
index 80b196b..40a9b30 100644
--- xen/include/public/io/protocols.h
+++ xen/include/public/io/protocols.h
@@ -16,10 +16,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2008, Keir Fraser
  */
 
 #ifndef __XEN_PROTOCOLS_H__
 #define __XEN_PROTOCOLS_H__
 
diff --git xen/include/public/physdev.h xen/include/public/physdev.h
index c9be6de..0e54635 100644
--- xen/include/public/physdev.h
+++ xen/include/public/physdev.h
@@ -14,10 +14,12 @@
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2006, Keir Fraser
  */
 
 #ifndef __XEN_PUBLIC_PHYSDEV_H__
 #define __XEN_PUBLIC_PHYSDEV_H__
 
diff --git xen/include/public/pmu.h xen/include/public/pmu.h
index 1149678..7753df0 100644
--- xen/include/public/pmu.h
+++ xen/include/public/pmu.h
@@ -1,5 +1,27 @@
+/*
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
+ */
+
 #ifndef __XEN_PUBLIC_PMU_H__
 #define __XEN_PUBLIC_PMU_H__
 
 #include "xen.h"
 #if defined(__i386__) || defined(__x86_64__)
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-22 14:02 Mike Belopuhov
@ 2015-09-24 10:45 ` Ian Campbell
  2015-09-24 13:17   ` Boris Ostrovsky
  2015-09-24 16:06   ` Wei Liu
  2015-09-25  7:12 ` Jan Beulich
  1 sibling, 2 replies; 18+ messages in thread
From: Ian Campbell @ 2015-09-24 10:45 UTC (permalink / raw)
  To: Mike Belopuhov, xen-devel, Wei Liu; +Cc: Boris Ostrovsky, Keir Fraser

On Tue, 2015-09-22 at 16:02 +0200, Mike Belopuhov wrote:
> The copyright line indicates a person, a group of people and/or a company
> granting rights stated in the license text and is a required part of the
> license.
> 
> The year of the copyright is chosen to be the same as when the license has
> been applied to the file or when the file has been created in case there
> was no license.  It is possible to update or add additional years if major
> changes have been done to the the file, but is generally not a requirement.
> 
> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>

LGTM, thanks. I'll wait for Konrad and/or Boris to confirm that Oracle are
happy with this wording etc. Keir's one matches all his others so I think
we can assume it is ok unless we hear otherwise.

Wei, I can't think of a reason not to include this in 4.6, does that work
for you?

> ---
>  xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
>  xen/include/public/hvm/e820.h           |  3 ++-
>  xen/include/public/hvm/hvm_info_table.h |  2 ++
>  xen/include/public/hvm/hvm_op.h         |  2 ++
>  xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>  xen/include/public/hvm/params.h         |  2 ++
>  xen/include/public/io/protocols.h       |  2 ++
>  xen/include/public/physdev.h            |  2 ++
>  xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
>  9 files changed, 58 insertions(+), 1 deletion(-)
> 
> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
> -x86/pmu.h
> index 1a53888..68ebf12 100644
> --- xen/include/public/arch-x86/pmu.h
> +++ xen/include/public/arch-x86/pmu.h
> @@ -1,5 +1,27 @@
> +/*
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to
> + * deal in the Software without restriction, including without
> limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> + * sell copies of the Software, and to permit persons to whom the
> Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
> + */
> +
>  #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>  #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>  
>  /* x86-specific PMU definitions */
>  
> diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
> index 5bdc227..6c58a37 100644
> --- xen/include/public/hvm/e820.h
> +++ xen/include/public/hvm/e820.h
> @@ -1,6 +1,5 @@
> -
>  /*
>   * Permission is hereby granted, free of charge, to any person obtaining
> a copy
>   * of this software and associated documentation files (the "Software"),
> to
>   * deal in the Software without restriction, including without
> limitation the
>   * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> @@ -15,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_E820_H__
>  #define __XEN_PUBLIC_HVM_E820_H__
>  
> diff --git xen/include/public/hvm/hvm_info_table.h
> xen/include/public/hvm/hvm_info_table.h
> index 36085fa..9e3f807 100644
> --- xen/include/public/hvm/hvm_info_table.h
> +++ xen/include/public/hvm/hvm_info_table.h
> @@ -18,10 +18,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>  #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>  
> diff --git xen/include/public/hvm/hvm_op.h
> xen/include/public/hvm/hvm_op.h
> index 014546a..1606185 100644
> --- xen/include/public/hvm/hvm_op.h
> +++ xen/include/public/hvm/hvm_op.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2007, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>  #define __XEN_PUBLIC_HVM_HVM_OP_H__
>  
> diff --git xen/include/public/hvm/hvm_xs_strings.h
> xen/include/public/hvm/hvm_xs_strings.h
> index 8aec935..146b0b0 100644
> --- xen/include/public/hvm/hvm_xs_strings.h
> +++ xen/include/public/hvm/hvm_xs_strings.h
> @@ -18,10 +18,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2013, Citrix Systems
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>  #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>  
> diff --git xen/include/public/hvm/params.h
> xen/include/public/hvm/params.h
> index 147d9b8..356dfd3 100644
> --- xen/include/public/hvm/params.h
> +++ xen/include/public/hvm/params.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2007, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>  #define __XEN_PUBLIC_HVM_PARAMS_H__
>  
> diff --git xen/include/public/io/protocols.h
> xen/include/public/io/protocols.h
> index 80b196b..40a9b30 100644
> --- xen/include/public/io/protocols.h
> +++ xen/include/public/io/protocols.h
> @@ -16,10 +16,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2008, Keir Fraser
>   */
>  
>  #ifndef __XEN_PROTOCOLS_H__
>  #define __XEN_PROTOCOLS_H__
>  
> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
> index c9be6de..0e54635 100644
> --- xen/include/public/physdev.h
> +++ xen/include/public/physdev.h
> @@ -14,10 +14,12 @@
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
>   * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>   * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2006, Keir Fraser
>   */
>  
>  #ifndef __XEN_PUBLIC_PHYSDEV_H__
>  #define __XEN_PUBLIC_PHYSDEV_H__
>  
> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
> index 1149678..7753df0 100644
> --- xen/include/public/pmu.h
> +++ xen/include/public/pmu.h
> @@ -1,5 +1,27 @@
> +/*
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to
> + * deal in the Software without restriction, including without
> limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
> and/or
> + * sell copies of the Software, and to permit persons to whom the
> Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
> + */
> +
>  #ifndef __XEN_PUBLIC_PMU_H__
>  #define __XEN_PUBLIC_PMU_H__
>  
>  #include "xen.h"
>  #if defined(__i386__) || defined(__x86_64__)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-24 10:45 ` Ian Campbell
@ 2015-09-24 13:17   ` Boris Ostrovsky
  2015-09-24 15:04     ` Konrad Rzeszutek Wilk
  2015-09-24 16:06   ` Wei Liu
  1 sibling, 1 reply; 18+ messages in thread
From: Boris Ostrovsky @ 2015-09-24 13:17 UTC (permalink / raw)
  To: Ian Campbell, Mike Belopuhov, xen-devel, Wei Liu; +Cc: Keir Fraser

On 09/24/2015 06:45 AM, Ian Campbell wrote:
> On Tue, 2015-09-22 at 16:02 +0200, Mike Belopuhov wrote:
>> The copyright line indicates a person, a group of people and/or a company
>> granting rights stated in the license text and is a required part of the
>> license.
>>
>> The year of the copyright is chosen to be the same as when the license has
>> been applied to the file or when the file has been created in case there
>> was no license.  It is possible to update or add additional years if major
>> changes have been done to the the file, but is generally not a requirement.
>>
>> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
> LGTM, thanks. I'll wait for Konrad and/or Boris to confirm that Oracle are
> happy with this wording etc.

This looks like we were told it should look, so I am OK with this.

-boris

> Keir's one matches all his others so I think
> we can assume it is ok unless we hear otherwise.
>
> Wei, I can't think of a reason not to include this in 4.6, does that work
> for you?
>
>> ---
>>   xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
>>   xen/include/public/hvm/e820.h           |  3 ++-
>>   xen/include/public/hvm/hvm_info_table.h |  2 ++
>>   xen/include/public/hvm/hvm_op.h         |  2 ++
>>   xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>>   xen/include/public/hvm/params.h         |  2 ++
>>   xen/include/public/io/protocols.h       |  2 ++
>>   xen/include/public/physdev.h            |  2 ++
>>   xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
>>   9 files changed, 58 insertions(+), 1 deletion(-)
>>
>> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
>> -x86/pmu.h
>> index 1a53888..68ebf12 100644
>> --- xen/include/public/arch-x86/pmu.h
>> +++ xen/include/public/arch-x86/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   
>>   /* x86-specific PMU definitions */
>>   
>> diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
>> index 5bdc227..6c58a37 100644
>> --- xen/include/public/hvm/e820.h
>> +++ xen/include/public/hvm/e820.h
>> @@ -1,6 +1,5 @@
>> -
>>   /*
>>    * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>>    * of this software and associated documentation files (the "Software"),
>> to
>>    * deal in the Software without restriction, including without
>> limitation the
>>    * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> @@ -15,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_E820_H__
>>   #define __XEN_PUBLIC_HVM_E820_H__
>>   
>> diff --git xen/include/public/hvm/hvm_info_table.h
>> xen/include/public/hvm/hvm_info_table.h
>> index 36085fa..9e3f807 100644
>> --- xen/include/public/hvm/hvm_info_table.h
>> +++ xen/include/public/hvm/hvm_info_table.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   
>> diff --git xen/include/public/hvm/hvm_op.h
>> xen/include/public/hvm/hvm_op.h
>> index 014546a..1606185 100644
>> --- xen/include/public/hvm/hvm_op.h
>> +++ xen/include/public/hvm/hvm_op.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>>   #define __XEN_PUBLIC_HVM_HVM_OP_H__
>>   
>> diff --git xen/include/public/hvm/hvm_xs_strings.h
>> xen/include/public/hvm/hvm_xs_strings.h
>> index 8aec935..146b0b0 100644
>> --- xen/include/public/hvm/hvm_xs_strings.h
>> +++ xen/include/public/hvm/hvm_xs_strings.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2013, Citrix Systems
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   
>> diff --git xen/include/public/hvm/params.h
>> xen/include/public/hvm/params.h
>> index 147d9b8..356dfd3 100644
>> --- xen/include/public/hvm/params.h
>> +++ xen/include/public/hvm/params.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>>   #define __XEN_PUBLIC_HVM_PARAMS_H__
>>   
>> diff --git xen/include/public/io/protocols.h
>> xen/include/public/io/protocols.h
>> index 80b196b..40a9b30 100644
>> --- xen/include/public/io/protocols.h
>> +++ xen/include/public/io/protocols.h
>> @@ -16,10 +16,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2008, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PROTOCOLS_H__
>>   #define __XEN_PROTOCOLS_H__
>>   
>> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
>> index c9be6de..0e54635 100644
>> --- xen/include/public/physdev.h
>> +++ xen/include/public/physdev.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_PHYSDEV_H__
>>   #define __XEN_PUBLIC_PHYSDEV_H__
>>   
>> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
>> index 1149678..7753df0 100644
>> --- xen/include/public/pmu.h
>> +++ xen/include/public/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_PMU_H__
>>   #define __XEN_PUBLIC_PMU_H__
>>   
>>   #include "xen.h"
>>   #if defined(__i386__) || defined(__x86_64__)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-24 13:17   ` Boris Ostrovsky
@ 2015-09-24 15:04     ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 18+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-09-24 15:04 UTC (permalink / raw)
  To: Boris Ostrovsky, Ian Campbell, Mike Belopuhov, xen-devel, Wei Liu
  Cc: Keir Fraser

On September 24, 2015 9:17:08 AM EDT, Boris Ostrovsky <boris.ostrovsky@oracle.com> wrote:
>On 09/24/2015 06:45 AM, Ian Campbell wrote:
>> On Tue, 2015-09-22 at 16:02 +0200, Mike Belopuhov wrote:
>>> The copyright line indicates a person, a group of people and/or a
>company
>>> granting rights stated in the license text and is a required part of
>the
>>> license.
>>>
>>> The year of the copyright is chosen to be the same as when the
>license has
>>> been applied to the file or when the file has been created in case
>there
>>> was no license.  It is possible to update or add additional years if
>major
>>> changes have been done to the the file, but is generally not a
>requirement.
>>>
>>> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
>> LGTM, thanks. I'll wait for Konrad and/or Boris to confirm that
>Oracle are
>> happy with this wording etc.
>
>This looks like we were told it should look, so I am OK with this.
>

Ditto, though I think you need to provide an official Acked-by.

>-boris
>
>> Keir's one matches all his others so I think
>> we can assume it is ok unless we hear otherwise.
>>
>> Wei, I can't think of a reason not to include this in 4.6, does that
>work
>> for you?
>>
>>> ---
>>>   xen/include/public/arch-x86/pmu.h       | 22
>++++++++++++++++++++++
>>>   xen/include/public/hvm/e820.h           |  3 ++-
>>>   xen/include/public/hvm/hvm_info_table.h |  2 ++
>>>   xen/include/public/hvm/hvm_op.h         |  2 ++
>>>   xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>>>   xen/include/public/hvm/params.h         |  2 ++
>>>   xen/include/public/io/protocols.h       |  2 ++
>>>   xen/include/public/physdev.h            |  2 ++
>>>   xen/include/public/pmu.h                | 22
>++++++++++++++++++++++
>>>   9 files changed, 58 insertions(+), 1 deletion(-)
>>>
>>> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
>>> -x86/pmu.h
>>> index 1a53888..68ebf12 100644
>>> --- xen/include/public/arch-x86/pmu.h
>>> +++ xen/include/public/arch-x86/pmu.h
>>> @@ -1,5 +1,27 @@
>>> +/*
>>> + * Permission is hereby granted, free of charge, to any person
>obtaining
>>> a copy
>>> + * of this software and associated documentation files (the
>"Software"),
>>> to
>>> + * deal in the Software without restriction, including without
>>> limitation the
>>> + * rights to use, copy, modify, merge, publish, distribute,
>sublicense,
>>> and/or
>>> + * sell copies of the Software, and to permit persons to whom the
>>> Software is
>>> + * furnished to do so, subject to the following conditions:
>>> + *
>>> + * The above copyright notice and this permission notice shall be
>>> included in
>>> + * all copies or substantial portions of the Software.
>>> + *
>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> EXPRESS OR
>>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>>> MERCHANTABILITY,
>>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>>> OTHER
>>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>> + * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights
>reserved.
>>> + */
>>> +
>>>   #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>>>   #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>>>   
>>>   /* x86-specific PMU definitions */
>>>   
>>> diff --git xen/include/public/hvm/e820.h
>xen/include/public/hvm/e820.h
>>> index 5bdc227..6c58a37 100644
>>> --- xen/include/public/hvm/e820.h
>>> +++ xen/include/public/hvm/e820.h
>>> @@ -1,6 +1,5 @@
>>> -
>>>   /*
>>>    * Permission is hereby granted, free of charge, to any person
>obtaining
>>> a copy
>>>    * of this software and associated documentation files (the
>"Software"),
>>> to
>>>    * deal in the Software without restriction, including without
>>> limitation the
>>>    * rights to use, copy, modify, merge, publish, distribute,
>sublicense,
>>> and/or
>>> @@ -15,10 +14,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2006, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_HVM_E820_H__
>>>   #define __XEN_PUBLIC_HVM_E820_H__
>>>   
>>> diff --git xen/include/public/hvm/hvm_info_table.h
>>> xen/include/public/hvm/hvm_info_table.h
>>> index 36085fa..9e3f807 100644
>>> --- xen/include/public/hvm/hvm_info_table.h
>>> +++ xen/include/public/hvm/hvm_info_table.h
>>> @@ -18,10 +18,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2006, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>>   #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>>   
>>> diff --git xen/include/public/hvm/hvm_op.h
>>> xen/include/public/hvm/hvm_op.h
>>> index 014546a..1606185 100644
>>> --- xen/include/public/hvm/hvm_op.h
>>> +++ xen/include/public/hvm/hvm_op.h
>>> @@ -14,10 +14,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2007, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>>>   #define __XEN_PUBLIC_HVM_HVM_OP_H__
>>>   
>>> diff --git xen/include/public/hvm/hvm_xs_strings.h
>>> xen/include/public/hvm/hvm_xs_strings.h
>>> index 8aec935..146b0b0 100644
>>> --- xen/include/public/hvm/hvm_xs_strings.h
>>> +++ xen/include/public/hvm/hvm_xs_strings.h
>>> @@ -18,10 +18,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2013, Citrix Systems
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>>   #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>>   
>>> diff --git xen/include/public/hvm/params.h
>>> xen/include/public/hvm/params.h
>>> index 147d9b8..356dfd3 100644
>>> --- xen/include/public/hvm/params.h
>>> +++ xen/include/public/hvm/params.h
>>> @@ -14,10 +14,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2007, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>>>   #define __XEN_PUBLIC_HVM_PARAMS_H__
>>>   
>>> diff --git xen/include/public/io/protocols.h
>>> xen/include/public/io/protocols.h
>>> index 80b196b..40a9b30 100644
>>> --- xen/include/public/io/protocols.h
>>> +++ xen/include/public/io/protocols.h
>>> @@ -16,10 +16,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2008, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PROTOCOLS_H__
>>>   #define __XEN_PROTOCOLS_H__
>>>   
>>> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
>>> index c9be6de..0e54635 100644
>>> --- xen/include/public/physdev.h
>>> +++ xen/include/public/physdev.h
>>> @@ -14,10 +14,12 @@
>>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
>OR
>>> OTHER
>>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>>    * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2006, Keir Fraser
>>>    */
>>>   
>>>   #ifndef __XEN_PUBLIC_PHYSDEV_H__
>>>   #define __XEN_PUBLIC_PHYSDEV_H__
>>>   
>>> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
>>> index 1149678..7753df0 100644
>>> --- xen/include/public/pmu.h
>>> +++ xen/include/public/pmu.h
>>> @@ -1,5 +1,27 @@
>>> +/*
>>> + * Permission is hereby granted, free of charge, to any person
>obtaining
>>> a copy
>>> + * of this software and associated documentation files (the
>"Software"),
>>> to
>>> + * deal in the Software without restriction, including without
>>> limitation the
>>> + * rights to use, copy, modify, merge, publish, distribute,
>sublicense,
>>> and/or
>>> + * sell copies of the Software, and to permit persons to whom the
>>> Software is
>>> + * furnished to do so, subject to the following conditions:
>>> + *
>>> + * The above copyright notice and this permission notice shall be
>>> included in
>>> + * all copies or substantial portions of the Software.
>>> + *
>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> EXPRESS OR
>>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>>> MERCHANTABILITY,
>>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
>EVENT
>>> SHALL THE
>>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>>> OTHER
>>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>>> ARISING
>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>OTHER
>>> + * DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Copyright (c) 2015 Oracle and/or its affiliates. All rights
>reserved.
>>> + */
>>> +
>>>   #ifndef __XEN_PUBLIC_PMU_H__
>>>   #define __XEN_PUBLIC_PMU_H__
>>>   
>>>   #include "xen.h"
>>>   #if defined(__i386__) || defined(__x86_64__)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-24 10:45 ` Ian Campbell
  2015-09-24 13:17   ` Boris Ostrovsky
@ 2015-09-24 16:06   ` Wei Liu
  1 sibling, 0 replies; 18+ messages in thread
From: Wei Liu @ 2015-09-24 16:06 UTC (permalink / raw)
  To: Ian Campbell
  Cc: Keir Fraser, xen-devel, Mike Belopuhov, Wei Liu, Boris Ostrovsky

On Thu, Sep 24, 2015 at 11:45:56AM +0100, Ian Campbell wrote:
> On Tue, 2015-09-22 at 16:02 +0200, Mike Belopuhov wrote:
> > The copyright line indicates a person, a group of people and/or a company
> > granting rights stated in the license text and is a required part of the
> > license.
> > 
> > The year of the copyright is chosen to be the same as when the license has
> > been applied to the file or when the file has been created in case there
> > was no license.  It is possible to update or add additional years if major
> > changes have been done to the the file, but is generally not a requirement.
> > 
> > Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
> 
> LGTM, thanks. I'll wait for Konrad and/or Boris to confirm that Oracle are
> happy with this wording etc. Keir's one matches all his others so I think
> we can assume it is ok unless we hear otherwise.
> 
> Wei, I can't think of a reason not to include this in 4.6, does that work
> for you?
> 

Of course this should be included in 4.6.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-22 14:02 Mike Belopuhov
  2015-09-24 10:45 ` Ian Campbell
@ 2015-09-25  7:12 ` Jan Beulich
  2015-09-28  9:24   ` Mike Belopuhov
  1 sibling, 1 reply; 18+ messages in thread
From: Jan Beulich @ 2015-09-25  7:12 UTC (permalink / raw)
  To: Mike Belopuhov; +Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell, xen-devel

>>> On 22.09.15 at 16:02, <mike.belopuhov@esdenera.com> wrote:
> --- xen/include/public/arch-x86/pmu.h
> +++ xen/include/public/arch-x86/pmu.h

I fixed this up for you this time, but in the future please make sure
you send patches in conventional format (applicable with patch's -p1
or whatever tool's equivalent).

Thanks, Jan

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-25  7:12 ` Jan Beulich
@ 2015-09-28  9:24   ` Mike Belopuhov
  2015-09-29 12:03     ` Mike Belopuhov
  0 siblings, 1 reply; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-28  9:24 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell, xen-devel

On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote:
> >>> On 22.09.15 at 16:02, <mike.belopuhov@esdenera.com> wrote:
> > --- xen/include/public/arch-x86/pmu.h
> > +++ xen/include/public/arch-x86/pmu.h
> 
> I fixed this up for you this time, but in the future please make sure
> you send patches in conventional format (applicable with patch's -p1
> or whatever tool's equivalent).
> 
> Thanks, Jan
> 

Thanks, Jan.  I'll keep that in mind.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-28  9:24   ` Mike Belopuhov
@ 2015-09-29 12:03     ` Mike Belopuhov
  2015-09-29 12:23       ` Andrew Cooper
  0 siblings, 1 reply; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-29 12:03 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell, xen-devel

On Mon, Sep 28, 2015 at 11:24 +0200, Mike Belopuhov wrote:
> On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote:
> > >>> On 22.09.15 at 16:02, <mike.belopuhov@esdenera.com> wrote:
> > > --- xen/include/public/arch-x86/pmu.h
> > > +++ xen/include/public/arch-x86/pmu.h
> > 
> > I fixed this up for you this time, but in the future please make sure
> > you send patches in conventional format (applicable with patch's -p1
> > or whatever tool's equivalent).
> > 
> > Thanks, Jan
> > 
> 
> Thanks, Jan.  I'll keep that in mind.

Hi Guys,

Are we waiting for others to Ack the diff or is there anything
I should do?

With best regards,
Mike

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-29 12:03     ` Mike Belopuhov
@ 2015-09-29 12:23       ` Andrew Cooper
  2015-09-29 13:34         ` Mike Belopuhov
  0 siblings, 1 reply; 18+ messages in thread
From: Andrew Cooper @ 2015-09-29 12:23 UTC (permalink / raw)
  To: Mike Belopuhov, Jan Beulich
  Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell, xen-devel

On 29/09/15 13:03, Mike Belopuhov wrote:
> On Mon, Sep 28, 2015 at 11:24 +0200, Mike Belopuhov wrote:
>> On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote:
>>>>>> On 22.09.15 at 16:02, <mike.belopuhov@esdenera.com> wrote:
>>>> --- xen/include/public/arch-x86/pmu.h
>>>> +++ xen/include/public/arch-x86/pmu.h
>>> I fixed this up for you this time, but in the future please make sure
>>> you send patches in conventional format (applicable with patch's -p1
>>> or whatever tool's equivalent).
>>>
>>> Thanks, Jan
>>>
>> Thanks, Jan.  I'll keep that in mind.
> Hi Guys,
>
> Are we waiting for others to Ack the diff or is there anything
> I should do?
>
> With best regards,
> Mike

This has been committed (staging and staging-4.6)

http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=8d6ff9ef259e296e6aee32ad8840cc5081280e0d

In both cases, they have not yet passed the automatic test gate, which
is why they have not appeared in master and stable-4.6

~Andrew

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] Add missing license and copyright statements to public interface headers.
  2015-09-29 12:23       ` Andrew Cooper
@ 2015-09-29 13:34         ` Mike Belopuhov
  0 siblings, 0 replies; 18+ messages in thread
From: Mike Belopuhov @ 2015-09-29 13:34 UTC (permalink / raw)
  To: Andrew Cooper
  Cc: Boris Ostrovsky, Keir Fraser, Ian Campbell, Jan Beulich,
	xen-devel

On Tue, Sep 29, 2015 at 13:23 +0100, Andrew Cooper wrote:
> On 29/09/15 13:03, Mike Belopuhov wrote:
> > On Mon, Sep 28, 2015 at 11:24 +0200, Mike Belopuhov wrote:
> >> On Fri, Sep 25, 2015 at 01:12 -0600, Jan Beulich wrote:
> >>>>>> On 22.09.15 at 16:02, <mike.belopuhov@esdenera.com> wrote:
> >>>> --- xen/include/public/arch-x86/pmu.h
> >>>> +++ xen/include/public/arch-x86/pmu.h
> >>> I fixed this up for you this time, but in the future please make sure
> >>> you send patches in conventional format (applicable with patch's -p1
> >>> or whatever tool's equivalent).
> >>>
> >>> Thanks, Jan
> >>>
> >> Thanks, Jan.  I'll keep that in mind.
> > Hi Guys,
> >
> > Are we waiting for others to Ack the diff or is there anything
> > I should do?
> >
> > With best regards,
> > Mike
> 
> This has been committed (staging and staging-4.6)
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=8d6ff9ef259e296e6aee32ad8840cc5081280e0d
> 
> In both cases, they have not yet passed the automatic test gate, which
> is why they have not appeared in master and stable-4.6
> 
> ~Andrew

Oh, pardon my impatience then!  And thanks a lot!

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2015-09-29 13:34 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 11:53 [PATCH] Add missing license and copyright statements to public interface headers Mike Belopuhov
2015-09-17 18:52 ` Konrad Rzeszutek Wilk
2015-09-18  8:44 ` Ian Campbell
2015-09-18 12:00   ` Boris Ostrovsky
2015-09-18 14:13     ` Konrad Rzeszutek Wilk
2015-09-22 11:42       ` Mike Belopuhov
2015-09-22 13:00         ` Konrad Rzeszutek Wilk
2015-09-22 13:58           ` Mike Belopuhov
  -- strict thread matches above, loose matches on Subject: below --
2015-09-22 14:02 Mike Belopuhov
2015-09-24 10:45 ` Ian Campbell
2015-09-24 13:17   ` Boris Ostrovsky
2015-09-24 15:04     ` Konrad Rzeszutek Wilk
2015-09-24 16:06   ` Wei Liu
2015-09-25  7:12 ` Jan Beulich
2015-09-28  9:24   ` Mike Belopuhov
2015-09-29 12:03     ` Mike Belopuhov
2015-09-29 12:23       ` Andrew Cooper
2015-09-29 13:34         ` Mike Belopuhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).