From mboxrd@z Thu Jan  1 00:00:00 1970
From: He Chen <he.chen@linux.intel.com>
Subject: Re: [PATCH v4 4/4] docs: add document to introduce CDP
 command
Date: Fri, 25 Sep 2015 18:16:04 +0800
Message-ID: <20150925101604.GA15813@HE>
References: <1442482536-12024-1-git-send-email-he.chen@linux.intel.com>
	<1442482536-12024-5-git-send-email-he.chen@linux.intel.com>
	<1443093722.10338.292.camel@citrix.com> <20150925092933.GC12290@HE>
	<1443175138.25250.102.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <he.chen@linux.intel.com>) id 1ZfQ2c-0005qp-TS
	for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 10:15:47 +0000
Content-Disposition: inline
In-Reply-To: <1443175138.25250.102.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, chao.p.peng@linux.intel.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Sep 25, 2015 at 10:58:58AM +0100, Ian Campbell wrote:
> On Fri, 2015-09-25 at 17:29 +0800, He Chen wrote:
> > On Thu, Sep 24, 2015 at 12:22:02PM +0100, Ian Campbell wrote:
> > > On Thu, 2015-09-17 at 17:35 +0800, He Chen wrote:
> > > > Add new CDP options with CAT commands in xl interface man page.
> > > > Add description of CDP in xl-psr.markdown.
> > > 
> > > It would have been fine to include this in the previous patch by the
> > > way.
> > > 
> > 
> > You mean include both xl man page and xl-psr.markdown in the previous
> > patch? Or just only xl man page?
> 
> All of the docs could validly be included with the patch which introduces
> the feature. i.e. you could fold patch #4 into #3 completely.
> 
> You don't have to if you don't want to.
> 

Thanks for your reminding, I will merge patch #3 and #4 in next version.

> > Maybe I make words a little confused here.
> > With CDP enabled, user can specify code cache (or data cache) only, and
> > the other would remain previous value (if no previous value, it would
> > keep as default value).
> 
> The value is just enabled or disabled, so do I understand correctly that
> this is what you can do if cdp is enabled:
> 
>     [now: code cbm=<default>; data cbm=<default>]
> 
>     xl psr-cat-cbm-set -c <domid> 0xdeadbeed
>     [now: code cbm=0xdeadbeef; data cbm=<default>]
> 
>     xl psr-cat-cbm-set -d <domid> 0xf00fb00f
>     [now: code cbm=0xdeadbeef; data cbm=0xf00fb00f]
> 
>     xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed
> 
>     [now: code cbm=0xd00dfeed; data cbm=0xd00dfeed]
> 
>     xl psr-cat-cbm-set <domid> 0xee11ee11
> 
>     [now: code cbm=0xee11ee11; data cbm=0xee11ee11]
> 
> Is that right?

Yes.

> 
> And if cdp is not enabled:
> 
>     [now: cbm=<default>]
> 
>     xl psr-cat-cbm-set -c <domid> 0xdeadbeed
>     *ERRROR*
>     [now: cbm=<default>]
> 
> xl psr-cat-cbm-set -d <domid> 0xf00fb00f
>     *ERRROR*
>     [now: cbm=<default>]
> 

Right above.

> xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed
> 
> *ERRROR*
> [now: cbm=<default>]
> 

In current code, it is valid since -c & -d have the same behaviour as
neither of them.
So, it will not show error, and cbm=0xd00dfeed

What do you think of this? Is it proper to do so?

> xl psr-cat-cbm-set <domid> 0xee11ee11
> 
> [now: cbm=0xee11ee11]
> 

Right.

> > So, I think independently would be fine here.
> 
> If I'm correct in all the above then yes.
> 
> Ian.