From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <Wei.Liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen: credit1: fix tickling when it happens from a remote pCPU
Date: Fri, 25 Sep 2015 12:05:13 +0100 [thread overview]
Message-ID: <20150925110513.GD4967@zion.uk.xensource.com> (raw)
In-Reply-To: <1443168645.3276.46.camel@citrix.com>
On Fri, Sep 25, 2015 at 10:10:45AM +0200, Dario Faggioli wrote:
> Hey Wei,
>
> On Fri, 2015-09-25 at 09:46 +0200, Dario Faggioli wrote:
>
> > For instance, this can happen when an HVM domain runs in a cpupool,
> > with a different scheduler than the default one, and issues IOREQs
> > to Dom0, running in Pool-0 with the default scheduler.
> > In fact, right in this case, the following crash can be observed:
>
> > (XEN) ----[ Xen-4.7-unstable x86_64 debug=y Tainted: C ]----
> > (XEN) CPU: 7
> > (XEN) RIP: e008:[<ffff82d0801230de>] __runq_tickle+0x18f/0x430
> > (XEN) RFLAGS: 0000000000010086 CONTEXT: hypervisor (d1v0)
> > (XEN) rax: 0000000000000001 rbx: ffff8303184fee00 rcx:
> > 0000000000000000
> > (XEN) ... ... ...
> > (XEN) Xen stack trace from rsp=ffff83031fa57a08:
> > (XEN) ffff82d0801fe664 ffff82d08033c820 0000000100000002
> > 0000000a00000001
> > (XEN) 0000000000006831 0000000000000000 0000000000000000
> > 0000000000000000
> > (XEN) ... ... ...
> > (XEN) Xen call trace:
> > (XEN) [<ffff82d0801230de>] __runq_tickle+0x18f/0x430
> > (XEN) [<ffff82d08012348a>] csched_vcpu_wake+0x10b/0x110
> > (XEN) [<ffff82d08012b421>] vcpu_wake+0x20a/0x3ce
> > (XEN) [<ffff82d08012b91c>] vcpu_unblock+0x4b/0x4e
> > (XEN) [<ffff82d080167bd0>] vcpu_kick+0x17/0x61
> > (XEN) [<ffff82d080167c46>] vcpu_mark_events_pending+0x2c/0x2f
> > (XEN) [<ffff82d08010ac35>] evtchn_fifo_set_pending+0x381/0x3f6
> > (XEN) [<ffff82d08010a0f6>] notify_via_xen_event_channel+0xc9/0xd6
> > (XEN) [<ffff82d0801c29ed>] hvm_send_ioreq+0x3e9/0x441
> > (XEN) [<ffff82d0801bba7d>] hvmemul_do_io+0x23f/0x2d2
> > (XEN) [<ffff82d0801bbb43>] hvmemul_do_io_buffer+0x33/0x64
> > (XEN) [<ffff82d0801bc92b>] hvmemul_do_pio_buffer+0x35/0x37
> > (XEN) [<ffff82d0801cc49f>] handle_pio+0x58/0x14c
> > (XEN) [<ffff82d0801eabcb>] vmx_vmexit_handler+0x16b3/0x1bea
> > (XEN) [<ffff82d0801efd21>] vmx_asm_vmexit_handler+0x41/0xc0
> >
> This patch is a bugfix, so I think it should be included in 4.6.
>
> I'm able to trigger the above Oops pretty reliably by running an HVM
> guest in a cpupool that has a scheduler different than Credit (by,
> e.g., starting some load in the guest itself, or even just simply doing
> `xl shutdown' on it).
>
> It may not be the most common of the configurations, but I think it's
> worth.
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> Thanks and Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>
next prev parent reply other threads:[~2015-09-25 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 7:46 [PATCH v2] xen: credit1: fix tickling when it happens from a remote pCPU Dario Faggioli
2015-09-25 8:10 ` Dario Faggioli
2015-09-25 11:05 ` Wei Liu [this message]
2015-09-29 13:47 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925110513.GD4967@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).