From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH for Xen 4.6 0/5] Several PSR fixes in libxl
Date: Tue, 29 Sep 2015 11:08:31 +0800
Message-ID: <20150929030830.GG5813@pengc-linux.bj.intel.com>
References: <1443441293-4287-1-git-send-email-chao.p.peng@linux.intel.com>
	<20150928141647.GG13821@zion.uk.xensource.com>
	<1443454945.3276.105.camel@citrix.com>
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1443454945.3276.105.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, xumengpanda@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Mon, Sep 28, 2015 at 05:42:25PM +0200, Dario Faggioli wrote:
> On Mon, 2015-09-28 at 15:16 +0100, Wei Liu wrote:
> > On Mon, Sep 28, 2015 at 07:54:48PM +0800, Chao Peng wrote:
> > > The patch basically contains several PSR fixes in libxl.
> > > patch1-3: fix the socket display error in certain hotplug case.
> > > patch4:   fix a minor range check.
> > > patch5:   improve the PSR document.
> > > 
> > > Detailed problem and fix please see commit message.
> > > 
> > 
> > I've gone through all patches. This series looks sensible to me. And
> > I
> > see the point of getting in it for 4.6 to avoid releasing APIs that
> > are
> > deemed buggy.
> > 
> FWIW, I totally agree.
> 
> The patch looks sensible to me too, I've only found a couple of minor
> issues.
> 
> > I would still like some more proof reading from someone who have
> > played
> > with this feature. I've CCed Dario and Meng.
> > 
> Thanks for pinging... I've done my best. :-)
> 
> About the suggestions I provided, the more important thing, IMO, is the
> name of the new function for retrieving the available sockets bitmap,
> which I really think it should be called libxl_get_online_socketmap(). 
> 
> The others are indeed minor things, which don't affect public APIs and
> hence --although I'd prefer to see them addressed-- we can fix/change
> them post 4.6 too.

Thanks for the quick followup from you guys. I will send another version
to address these comments.

Chao