From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH v5 1/3] x86: Support enable CDP by boot
 parameter and add get CDP status
Date: Wed, 30 Sep 2015 11:10:02 +0800
Message-ID: <20150930031002.GK5813@pengc-linux.bj.intel.com>
References: <1443428969-4695-1-git-send-email-he.chen@linux.intel.com>
	<1443428969-4695-2-git-send-email-he.chen@linux.intel.com>
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <chao.p.peng@linux.intel.com>) id 1Zh7qW-0006MZ-MF
	for xen-devel@lists.xenproject.org; Wed, 30 Sep 2015 03:14:20 +0000
Content-Disposition: inline
In-Reply-To: <1443428969-4695-2-git-send-email-he.chen@linux.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: He Chen <he.chen@linux.intel.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

>  
> +static inline bool_t cdp_is_enabled(unsigned int socket,
> +                                    unsigned long *cdp_socket_enable)

Since cdp_socket_enable is defined in file scope, I don't think it's
required to pass again.

Chao

> +{
> +    return cdp_socket_enable && test_bit(socket, cdp_socket_enable);
> +}