From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, keir@xen.org,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com, tim@xen.org
Subject: Re: [PATCH v1 1/3] libelf: Preserve log callback after elf_init
Date: Mon, 5 Oct 2015 10:23:31 -0400 [thread overview]
Message-ID: <20151005142331.GE2256@l.oracle.com> (raw)
In-Reply-To: <56126EDB02000078000A80D0@prv-mh.provo.novell.com>
On Mon, Oct 05, 2015 at 04:36:43AM -0600, Jan Beulich wrote:
> >>> On 03.10.15 at 20:39, <konrad.wilk@oracle.com> wrote:
> > The elf_init function uses the log callback to report
> > errors. But it also memsets the whole structure so the
> > log callback (if set) is wiped out!
>
> Only if you set it before calling elf_init(), which - looking at all current
> in-tree users isn't intended.
Right? But if you are developing against how else would
you find out that you have issues?
As in, if elf_init can't process the virtual address it tries
to call efi_msg to tell me what I did wrong, but that will always
end up silently (at least on user-space code).
>
> Jan
>
next prev parent reply other threads:[~2015-10-05 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 18:39 [PATCH] Various fixes - libelf, paging, blktap Konrad Rzeszutek Wilk
2015-10-03 18:39 ` [PATCH v1 1/3] libelf: Preserve log callback after elf_init Konrad Rzeszutek Wilk
2015-10-05 10:36 ` Jan Beulich
2015-10-05 14:23 ` Konrad Rzeszutek Wilk [this message]
2015-10-05 14:39 ` Jan Beulich
2015-10-05 14:48 ` Konrad Rzeszutek Wilk
2015-10-03 18:39 ` [PATCH v1 2/3] paging: Fix compile error when DEBUG_TRACE_DUMP is enabled Konrad Rzeszutek Wilk
2015-10-05 8:46 ` Andrew Cooper
2015-10-03 18:39 ` [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1 Konrad Rzeszutek Wilk
2015-10-05 8:49 ` Andrew Cooper
2015-10-05 10:46 ` Jan Beulich
2015-10-05 14:26 ` Konrad Rzeszutek Wilk
2015-10-05 14:46 ` Jan Beulich
2015-10-05 14:57 ` Konrad Rzeszutek Wilk
2015-10-05 15:02 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005142331.GE2256@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).