From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1 Date: Mon, 5 Oct 2015 10:26:48 -0400 Message-ID: <20151005142648.GF2256@l.oracle.com> References: <1443897590-5663-1-git-send-email-konrad.wilk@oracle.com> <1443897590-5663-4-git-send-email-konrad.wilk@oracle.com> <56123983.5040406@citrix.com> <5612713F02000078000A80E9@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zj6jC-0001PM-RJ for xen-devel@lists.xenproject.org; Mon, 05 Oct 2015 14:26:58 +0000 Content-Disposition: inline In-Reply-To: <5612713F02000078000A80E9@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, ian.campbell@citrix.com, Andrew Cooper , tim@xen.org, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: > >>> On 05.10.15 at 10:49, wrote: > > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: > >> I get compile warnings telling me that > >> s->connections[i].fd == fd > >> > >> 'i' may be past the array. Adding in an extra condition > >> on the loop fixes that. > >> > >> Signed-off-by: Konrad Rzeszutek Wilk > > > > Reviewed-by: Andrew Cooper > > > > Furthermore, I can't see any logic which prevents s->connected getting > > larger than MAX_CONNECTIONS > > Iirc Olaf had already suggested such a patch quite some time ago, > and not having seen the point back then I also don't see the point > now: ctl_accept() prevents ->connected from growing beyond 1, > and there's no other place where the value could get incremented. Thoughts on what to do about the compiler warnings which make this compiler errors (since we compile with -Werror) and one can't compile Xen? A different fix (make s->connected not be an array?) > > Also, Konrad, regarding the subject (since this repeats from an > earlier patch of yours) - why do you reference a specific, non- > release version of gcc? Why not simply say 5.x? Because if the > problem is indeed only present in a non-release version, I don't > think we should bother working around such issues. I just ran 'gcc --version' and that is what it spit out. Since it is part of an official Fedora release I figured it is 'released' in some way? > > Jan >