xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
	Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	zhigang.x.wang@oracle.com
Subject: Re: [PATCH] tools: remove unused wrappers for python
Date: Wed, 7 Oct 2015 04:58:05 +0200	[thread overview]
Message-ID: <20151007025805.GA2267@mail-itl> (raw)
In-Reply-To: <20151006111849.GW29124@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1440 bytes --]

On Tue, Oct 06, 2015 at 12:18:50PM +0100, Wei Liu wrote:
> On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote:
> > Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they
> > are not used anywhere in the tree. In fact only one function is still
> > being used from pygrub, namely "xeninfo". All other users seem to have
> > gone with nuking xm/xend.
> > 
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Andrew said the python module is useful for debugging purpose. There are
> out-of-tree users as well.
> 
> I'm not too fussed about either keeping these functions or removing
> them. But I would like to leave some time for other people to object.

In QubesOS we use xc bindings. In the most recent version only for
memory managing (domain_set_target_mem, domain_setmaxmem,
domain_getinfo, physinfo).
https://github.com/QubesOS/qubes-core-admin/blob/master/qmemman/qmemman.py

This is used for real-time memory adjustment based on domain needs
(think: give domain more memory when needed, before it start swapping),
so directly manipulating with xc/xs is preferred over much slower
alternatives like libvirt. Libxl would be probably enough, but libxl
python bindings effectively doesn't exists.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

[-- Attachment #1.2: Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      parent reply	other threads:[~2015-10-07  2:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 10:46 [PATCH] tools: remove unused wrappers for python Juergen Gross
2015-10-06 11:18 ` Wei Liu
2015-10-06 11:33   ` Juergen Gross
2015-10-06 11:39     ` Wei Liu
2015-10-06 13:40       ` Ian Campbell
2015-10-06 14:51         ` Juergen Gross
2015-10-06 15:11           ` Ian Campbell
2015-10-06 15:21             ` Juergen Gross
2015-10-06 15:26               ` Ian Campbell
2015-10-06 15:30                 ` Zhigang Wang
2015-10-06 15:45                   ` Ian Campbell
2015-10-06 16:14                     ` Juergen Gross
2015-10-06 16:24                       ` Ian Campbell
2015-10-08  1:10                         ` Konrad Rzeszutek Wilk
2015-10-08  4:16                           ` Juergen Gross
2015-10-08 14:30                             ` Ian Campbell
2015-10-06 15:38                 ` Andrew Cooper
2015-10-06 16:31                   ` Wei Liu
2015-10-06 16:38                     ` Ian Campbell
2015-10-06 16:42                       ` Wei Liu
2015-10-06 15:24           ` Zhigang Wang
2015-10-08 14:38             ` Ian Campbell
2015-10-08 15:09               ` Zhigang Wang
2015-10-08 15:27                 ` Ian Campbell
2015-10-08 16:32                   ` Zhigang Wang
2015-10-08 16:58                     ` Wei Liu
2015-10-09  4:42                     ` Juergen Gross
2015-10-09  9:43                       ` Ian Campbell
2015-10-09 10:16                         ` Juergen Gross
2015-10-09 13:29                       ` Andrew Cooper
2015-10-07  2:58   ` Marek Marczykowski-Górecki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151007025805.GA2267@mail-itl \
    --to=marmarek@invisiblethingslab.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhigang.x.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).