From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM Date: Wed, 14 Oct 2015 10:07:19 +0800 Message-ID: <20151014020719.GB4427@pengc-linux.bj.intel.com> References: <1444726426-10567-1-git-send-email-he.chen@linux.intel.com> <1444726426-10567-3-git-send-email-he.chen@linux.intel.com> <561D41B202000078000AAAD8@prv-mh.provo.novell.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZmBXI-0005sN-NQ for xen-devel@lists.xenproject.org; Wed, 14 Oct 2015 02:11:24 +0000 Content-Disposition: inline In-Reply-To: <561D41B202000078000AAAD8@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, He Chen , ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Oct 13, 2015 at 09:38:58AM -0600, Jan Beulich wrote: > >>> On 13.10.15 at 10:53, wrote: > > @@ -331,19 +357,34 @@ static bool_t psr_check_cbm(unsigned int cbm_len, uint64_t cbm) > > struct cos_cbm_info > > { > > unsigned int cos; > > - uint64_t cbm; > > + uint64_t cbm_code; > > + uint64_t cbm_data; > > + bool_t cdp; > > }; > > The bool_t field really fits well in the gap between the first and second > one; I'll take the liberty to adjust this when committing (unless Chao > comes forward with further comments; otherwise I'm kind of hoping > for a Reviewed-by-him). Correct, it can be a optimization and I don't see any problem. So please feel free to adjust it. Thereby: Reviewed-by: Chao Peng > > Jan