From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: minios-devel@lists.xenproject.org,
Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH MINI-OS] xenbus: notify the other end when necessary
Date: Mon, 26 Oct 2015 13:21:51 +0100 [thread overview]
Message-ID: <20151026122151.GC19459@var.bordeaux.inria.fr> (raw)
In-Reply-To: <20151026121442.GD13118@zion.uk.xensource.com>
Wei Liu, le Mon 26 Oct 2015 12:14:43 +0000, a écrit :
> In my patch, mini-os notifies remote whenever it consumes a message,
> which I think it's slightly better because backend can start putting
> things in the ring as mini-os processes them.
That makes more notifications, but that can lead to more pipelining
indeed. That's what the Linux driver does, so let's do the same.
Also, I'm realizing: aren't we missing a full memory barrier between
the memcpy_from_ring call and xenstore_buf->rsp_cons += ? (in the two
places) We need to make sure to have finished copying from the ring
before writing the new rsp_cons.
Samuel
next prev parent reply other threads:[~2015-10-26 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 9:47 [PATCH MINI-OS] xenbus: notify the other end when necessary Wei Liu
2015-10-26 12:02 ` Samuel Thibault
2015-10-26 12:14 ` Wei Liu
2015-10-26 12:21 ` Samuel Thibault [this message]
2015-10-26 12:30 ` Wei Liu
2015-10-26 12:33 ` Samuel Thibault
2015-10-26 12:36 ` [Minios-devel] " Wei Liu
2015-11-02 12:14 ` Ian Campbell
2015-11-02 15:00 ` Wei Liu
2015-11-02 15:08 ` Ian Campbell
2015-11-02 15:53 ` Wei Liu
2015-11-02 16:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026122151.GC19459@var.bordeaux.inria.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=minios-devel@lists.xenproject.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).