Re: Ping: [PATCH v3] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Oct 26, 2015 at 03:42:07PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [Xen-devel] Ping: [PATCH v3] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()"):
> > On Mon, Oct 26, 2015 at 07:09:06AM -0600, Jan Beulich wrote:
> > > Tools maintainers, could I please get an ack or otherwise on this
> > > adjustment?
> 
> I confess I'm out of my depth here.  But thanks to Andrew Cooper's
> review, I'm happy to ack it without understanding it, except:
> 
> > Does it make sense to use inverse logic that you set a flag to not
> > mark permanent pages dirty? I think that's a bit awkward, not sure if it
> > is worth it.
> > 
> > I also realise that libxenctrl doesn't have stable interface so I'm a
> > bit two-minded for this.
> 
> What kind of out of tree callers are going to use xc_shadow_control ?
> 

I was assuming some random third party tools make use of
xc_shadow_control just to get the dirty bitmap of the guest.

I don't have concrete examples at hand though.  Maybe I'm too paranoid.

> Not qemu, AFAICT, which would be my main worry.
> 

OK. If you don't have further concern I'm happy to ack this patch.

Wei.

> Ian.