From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: Ping: [PATCH v3] x86/HVM: correct page dirty
 marking in hvm_map_guest_frame_rw()
Date: Mon, 26 Oct 2015 16:17:36 +0000
Message-ID: <20151026161736.GD19925@zion.uk.xensource.com>
References: <5625202002000078000AC6C4@prv-mh.provo.novell.com>
	<562E340202000078000AE9CF@prv-mh.provo.novell.com>
	<20151026152009.GA18674@zion.uk.xensource.com>
	<562E5C2A02000078000AEBA3@prv-mh.provo.novell.com>
	<20151026160532.GC19925@zion.uk.xensource.com>
	<562E5FA102000078000AEC23@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=734318897=wei.liu2@citrix.com>)
	id 1ZqkSq-0001BQ-W5
	for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 16:17:41 +0000
Content-Disposition: inline
In-Reply-To: <562E5FA102000078000AEC23@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, Oct 26, 2015 at 10:15:13AM -0600, Jan Beulich wrote:
> >>> On 26.10.15 at 17:05, <wei.liu2@citrix.com> wrote:
> > On Mon, Oct 26, 2015 at 10:00:26AM -0600, Jan Beulich wrote:
> >> >>> On 26.10.15 at 16:20, <wei.liu2@citrix.com> wrote:
> >> > On Mon, Oct 26, 2015 at 07:09:06AM -0600, Jan Beulich wrote:
> >> >> >>> On 19.10.15 at 16:53, <JBeulich@suse.com> wrote:
> >> >> > --- a/tools/libxc/xc_sr_save.c
> >> >> > +++ b/tools/libxc/xc_sr_save.c
> >> >> > @@ -537,7 +537,8 @@ static int suspend_and_send_dirty(struct
> >> >> >      if ( xc_shadow_control(
> >> >> >               xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
> >> >> >               HYPERCALL_BUFFER(dirty_bitmap), ctx->save.p2m_size,
> >> >> > -             NULL, 0, &stats) != ctx->save.p2m_size )
> >> >> > +             NULL, XEN_DOMCTL_SHADOW_LOGDIRTY_FINAL, &stats) !=
> >> >> > +         ctx->save.p2m_size )
> >> >> >      {
> >> >> >          PERROR("Failed to retrieve logdirty bitmap");
> >> >> >          rc = -1;
> >> >> 
> >> >> Tools maintainers, could I please get an ack or otherwise on this
> >> >> adjustment?
> >> >> 
> >> > 
> >> > Er, there seems to be behaviour change that would cause external users
> >> > of xc_shadow_control cease to function properly.
> >> 
> >> What behavioral change do you see? So far we simply didn't care
> >> about those permanently mapped pages. Now we provide an
> >> option to include them.
> > 
> > Oh, this is fine then. I thought before we had always included the
> > permanent mapped pages in dirty bitmap. I was wrong. Sorry about the
> > noise.
> 
> No problem at all. Now - does that represent some non-standard
> for of an ack?
> 

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

> Jan