xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* ovmf fails to build in stagin-4.6
@ 2015-10-26  9:43 Olaf Hering
  2015-10-26 10:03 ` Wei Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Olaf Hering @ 2015-10-26  9:43 UTC (permalink / raw)
  To: xen-devel

For me ovmf fails to build in staging-4.6:

...
[  541s] + ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/lib --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking --enable-debug --disable-stubdom --disable-xen --docdir=/usr/share/doc/packages/xen --enable-ovmf --enable-docs --enable-tools --enable-systemd --with-systemd=/usr/lib/systemd/system --with-systemd-modules-load=/usr/lib/modules-load.d --enable-stubdom --enable-ioemu-stubdom --disable-c-stubdom --disable-caml-stubdom --disable-vtpm-stubdom --enable-vtpmmgr-stubdom
  --with-initddir=/etc/init.d
...
[  561s] + make -j2 debug_symbols=n -k
...
[  727s] Building ... /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/PeiHobLib.inf [X64]
[  727s] Building ... /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf [X64]
[  727s] make[7]: Entering directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiHobLib/PeiHobLib'
[  727s] "gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -ffunction-sections -fdata-sections -c -include AutoGen.h -DSTRING_ARRAY_NAME=PeiHobLibStrings -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large -DMDEPKG_NDEBUG -mno-mmx -mno-sse -o /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiHobLib/PeiHobLib/OUTPUT/./HobLib.obj -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Librar
 y/PeiHobLib/PeiHobLib/DEBUG -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include/X64 /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c
[  727s] make[7]: Entering directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt'
[  727s] "gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -ffunction-sections -fdata-sections -c -include AutoGen.h -DSTRING_ARRAY_NAME=PeiServicesTablePointerLibIdtStrings -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large -DMDEPKG_NDEBUG -mno-mmx -mno-sse -o /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/./PeiServicesTablePointer.obj -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T16
 0310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/DEBUG -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include/X64 /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c: In function 'MigratePeiServicesTablePointer':
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c:100:26: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
[  727s]    EFI_STATUS             Status;
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c: In function 'GetHobList':
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c:46:25: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
[  727s]    EFI_STATUS            Status;
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c: In function 'GetBootModeHob':
[  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c:212:26: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
[  727s]    EFI_STATUS             Status;
[  727s] GNUmakefile:310: recipe for target '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/PeiServicesTablePointer.obj' failed
[  727s] make[7]: Leaving directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt'
[  727s] make[7]: *** [/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/PeiServicesTablePointer.obj] Error 1

Does it compile for anyone?

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26  9:43 ovmf fails to build in stagin-4.6 Olaf Hering
@ 2015-10-26 10:03 ` Wei Liu
  2015-10-26 10:11   ` Olaf Hering
  0 siblings, 1 reply; 11+ messages in thread
From: Wei Liu @ 2015-10-26 10:03 UTC (permalink / raw)
  To: Olaf Hering; +Cc: wei.liu2, xen-devel

On Mon, Oct 26, 2015 at 10:43:15AM +0100, Olaf Hering wrote:
> For me ovmf fails to build in staging-4.6:
> 
> ...
> [  541s] + ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/lib --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking --enable-debug --disable-stubdom --disable-xen --docdir=/usr/share/doc/packages/xen --enable-ovmf --enable-docs --enable-tools --enable-systemd --with-systemd=/usr/lib/systemd/system --with-systemd-modules-load=/usr/lib/modules-load.d --enable-stubdom --enable-ioemu-stubdom --disable-c-stubdom --disable-caml-stubdom --disable-vtpm-stubdom --enable-vtpmmgr-stubd
 om --with-initddir=/etc/init.d
> ...
> [  561s] + make -j2 debug_symbols=n -k
> ...
> [  727s] Building ... /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/PeiHobLib.inf [X64]
> [  727s] Building ... /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf [X64]
> [  727s] make[7]: Entering directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiHobLib/PeiHobLib'
> [  727s] "gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -ffunction-sections -fdata-sections -c -include AutoGen.h -DSTRING_ARRAY_NAME=PeiHobLibStrings -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large -DMDEPKG_NDEBUG -mno-mmx -mno-sse -o /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiHobLib/PeiHobLib/OUTPUT/./HobLib.obj -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Libr
 ary/PeiHobLib/PeiHobLib/DEBUG -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include/X64 /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c
> [  727s] make[7]: Entering directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt'
> [  727s] "gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -ffunction-sections -fdata-sections -c -include AutoGen.h -DSTRING_ARRAY_NAME=PeiServicesTablePointerLibIdtStrings -m64 -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large -DMDEPKG_NDEBUG -mno-mmx -mno-sse -o /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/./PeiServicesTablePointer.obj -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T
 160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/DEBUG -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include -I/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Include/X64 /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c: In function 'MigratePeiServicesTablePointer':
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c:100:26: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
> [  727s]    EFI_STATUS             Status;
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c: In function 'GetHobList':
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c:46:25: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
> [  727s]    EFI_STATUS            Status;
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c: In function 'GetBootModeHob':
> [  727s] /home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/MdePkg/Library/PeiHobLib/HobLib.c:212:26: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
> [  727s]    EFI_STATUS             Status;
> [  727s] GNUmakefile:310: recipe for target '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/PeiServicesTablePointer.obj' failed
> [  727s] make[7]: Leaving directory '/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt'
> [  727s] make[7]: *** [/home/abuild/rpmbuild/BUILD/xen-4.6.20151022T160310.e4a1dcb/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/RELEASE_GCC44/X64/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt/OUTPUT/PeiServicesTablePointer.obj] Error 1
> 
> Does it compile for anyone?
> 

It compiles for me -- but I'm using gcc 4.9.

You seem to be using gcc 4.4. It wouldn't surprise me that upstream
broke older toolchain by chance.

And the fix should be simple. I will see if I can cook up a patch at
some point.


Wei.

> Olaf
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26 10:03 ` Wei Liu
@ 2015-10-26 10:11   ` Olaf Hering
  2015-10-26 10:13     ` Wei Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Olaf Hering @ 2015-10-26 10:11 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel

On Mon, Oct 26, Wei Liu wrote:

> On Mon, Oct 26, 2015 at 10:43:15AM +0100, Olaf Hering wrote:

> > Does it compile for anyone?
> It compiles for me -- but I'm using gcc 4.9.

I noticed that just now, fails only in Tumbleweed which used gcc-5.1.1.
Sorry for the noise.

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26 10:11   ` Olaf Hering
@ 2015-10-26 10:13     ` Wei Liu
  2015-10-26 11:13       ` Olaf Hering
  0 siblings, 1 reply; 11+ messages in thread
From: Wei Liu @ 2015-10-26 10:13 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, xen-devel

On Mon, Oct 26, 2015 at 11:11:16AM +0100, Olaf Hering wrote:
> On Mon, Oct 26, Wei Liu wrote:
> 
> > On Mon, Oct 26, 2015 at 10:43:15AM +0100, Olaf Hering wrote:
> 
> > > Does it compile for anyone?
> > It compiles for me -- but I'm using gcc 4.9.
> 
> I noticed that just now, fails only in Tumbleweed which used gcc-5.1.1.
> Sorry for the noise.
> 

Wait, so you're using gcc-5.1.1 but OVMF is reporting gcc-4.4 (see in
the path of output string), there might be another problem with
toolchain detection then.

Wei.

> Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26 10:13     ` Wei Liu
@ 2015-10-26 11:13       ` Olaf Hering
  2015-10-26 12:04         ` Wei Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Olaf Hering @ 2015-10-26 11:13 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel

On Mon, Oct 26, Wei Liu wrote:

> Wait, so you're using gcc-5.1.1 but OVMF is reporting gcc-4.4 (see in
> the path of output string), there might be another problem with
> toolchain detection then.

As Linus said: detect old and known to be problematic, everything else has to
be handled as "current". But see tools/firmware/ovmf-dir-remote/OvmfPkg/build.sh

    gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
    case $gcc_version in
      4.5.*)
        TARGET_TOOLS=GCC45
        ;;
      4.6.*)
        TARGET_TOOLS=GCC46
        ;;
      4.7.*)
        TARGET_TOOLS=GCC47
        ;;
      4.8.*)
        TARGET_TOOLS=GCC48
        ;;
      4.9.*|4.1[0-9].*)
        TARGET_TOOLS=GCC49
        ;;
      *)
        TARGET_TOOLS=GCC44
        ;;
    esac

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26 11:13       ` Olaf Hering
@ 2015-10-26 12:04         ` Wei Liu
  2015-10-27  7:12           ` Olaf Hering
  0 siblings, 1 reply; 11+ messages in thread
From: Wei Liu @ 2015-10-26 12:04 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, xen-devel

On Mon, Oct 26, 2015 at 12:13:40PM +0100, Olaf Hering wrote:
> On Mon, Oct 26, Wei Liu wrote:
> 
> > Wait, so you're using gcc-5.1.1 but OVMF is reporting gcc-4.4 (see in
> > the path of output string), there might be another problem with
> > toolchain detection then.
> 
> As Linus said: detect old and known to be problematic, everything else has to
> be handled as "current". But see tools/firmware/ovmf-dir-remote/OvmfPkg/build.sh
> 
>     gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
>     case $gcc_version in
>       4.5.*)
>         TARGET_TOOLS=GCC45
>         ;;
>       4.6.*)
>         TARGET_TOOLS=GCC46
>         ;;
>       4.7.*)
>         TARGET_TOOLS=GCC47
>         ;;
>       4.8.*)
>         TARGET_TOOLS=GCC48
>         ;;
>       4.9.*|4.1[0-9].*)
>         TARGET_TOOLS=GCC49
>         ;;
>       *)
>         TARGET_TOOLS=GCC44
>         ;;
>     esac

I think you have a stale repository. Try deleting ovmf-dir-remote ?

I can't comment how they handle toolchain detection though.

Wei.

> 
> Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-26 12:04         ` Wei Liu
@ 2015-10-27  7:12           ` Olaf Hering
  2015-10-27  9:01             ` Olaf Hering
  2015-10-27 10:39             ` Wei Liu
  0 siblings, 2 replies; 11+ messages in thread
From: Olaf Hering @ 2015-10-27  7:12 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel

On Mon, Oct 26, Wei Liu wrote:

> I think you have a stale repository. Try deleting ovmf-dir-remote ?

Its always built in a new clean chroot from the same set of sources.
I will see if forcing GCC49 will change anything.

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-27  7:12           ` Olaf Hering
@ 2015-10-27  9:01             ` Olaf Hering
  2015-10-27 10:39             ` Wei Liu
  1 sibling, 0 replies; 11+ messages in thread
From: Olaf Hering @ 2015-10-27  9:01 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel

On Tue, Oct 27, Olaf Hering wrote:

> I will see if forcing GCC49 will change anything.

This change works for me.

--- xen.spec    (revision 6)
+++ xen.spec    (working copy)
@@ -290,6 +290,7 @@
 ln -sfvbn ../qemu-xen-dir-remote             tools/qemu-xen-dir-remote
 ln -sfvbn ../qemu-xen-traditional-dir-remote tools/qemu-xen-traditional-dir-remote
 ln -sfvbn ../../seabios-dir-remote           tools/firmware/seabios-dir-remote
+find ovmf-dir-remote -type f -print0 | xargs -0 sed -i 's@GCC44$@GCC49@'
 mv -vf          ovmf-dir-remote              tools/firmware/ovmf-dir-remote
 ln -sfvbn ../mini-os-remote                  extras/mini-os-remote
 xzcat %{S:102} > tools/firmware/etherboot/ipxe.tar

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-27  7:12           ` Olaf Hering
  2015-10-27  9:01             ` Olaf Hering
@ 2015-10-27 10:39             ` Wei Liu
  2015-10-27 13:58               ` Olaf Hering
  1 sibling, 1 reply; 11+ messages in thread
From: Wei Liu @ 2015-10-27 10:39 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, xen-devel

On Tue, Oct 27, 2015 at 08:12:09AM +0100, Olaf Hering wrote:
> On Mon, Oct 26, Wei Liu wrote:
>
> > I think you have a stale repository. Try deleting ovmf-dir-remote ?
>
> Its always built in a new clean chroot from the same set of sources.
> I will see if forcing GCC49 will change anything.
>

That's weird.

Can you tell me which commit of OVMF you have? Here is what I have in
OvmfPkg/build.sh:

98       4.9.*|4.1[0-9].*|5.*.*)
99         TARGET_TOOLS=GCC49


The commit id in Config.mk is af9785a9ed61daea52b47f0bf448f1f228beee1e

Wei.

> Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-27 10:39             ` Wei Liu
@ 2015-10-27 13:58               ` Olaf Hering
  2015-10-27 14:03                 ` Wei Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Olaf Hering @ 2015-10-27 13:58 UTC (permalink / raw)
  To: Wei Liu; +Cc: xen-devel

Am 27.10.2015 um 11:39 schrieb Wei Liu:
> The commit id in Config.mk is af9785a9ed61daea52b47f0bf448f1f228beee1e

I think the staging-4.6 rev differs, but I will check my checkout script
if it picks the id from the wrong branch/file.

Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ovmf fails to build in stagin-4.6
  2015-10-27 13:58               ` Olaf Hering
@ 2015-10-27 14:03                 ` Wei Liu
  0 siblings, 0 replies; 11+ messages in thread
From: Wei Liu @ 2015-10-27 14:03 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, xen-devel

On Tue, Oct 27, 2015 at 02:58:36PM +0100, Olaf Hering wrote:
> Am 27.10.2015 um 11:39 schrieb Wei Liu:
> > The commit id in Config.mk is af9785a9ed61daea52b47f0bf448f1f228beee1e
> 
> I think the staging-4.6 rev differs, but I will check my checkout script
> if it picks the id from the wrong branch/file.
> 

Oh yes of course.

Silly me. You were talking about 4.6. That commit is not in 4.6.  Sorry
about that.

Wei.

> Olaf

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-10-27 14:03 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-26  9:43 ovmf fails to build in stagin-4.6 Olaf Hering
2015-10-26 10:03 ` Wei Liu
2015-10-26 10:11   ` Olaf Hering
2015-10-26 10:13     ` Wei Liu
2015-10-26 11:13       ` Olaf Hering
2015-10-26 12:04         ` Wei Liu
2015-10-27  7:12           ` Olaf Hering
2015-10-27  9:01             ` Olaf Hering
2015-10-27 10:39             ` Wei Liu
2015-10-27 13:58               ` Olaf Hering
2015-10-27 14:03                 ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).