From: Olaf Hering <olaf@aepfle.de>
To: Chunyan Liu <cyliu@suse.com>
Cc: jgross@suse.com, wei.liu2@citrix.com, ian.campbell@citrix.com,
george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, jfehlig@suse.com,
Simon Cao <caobosimon@gmail.com>
Subject: Re: [PATCH V8 3/7] libxl: add pvusb API
Date: Thu, 12 Nov 2015 12:32:00 +0100 [thread overview]
Message-ID: <20151112113200.GA302@aepfle.de> (raw)
In-Reply-To: <1445418510-19614-4-git-send-email-cyliu@suse.com>
On Wed, Oct 21, Chunyan Liu wrote:
> Add pvusb APIs, including:
Some comments below.
After a quick look I miss the proposed ctrl/device separation for pvscsi
(what handles "state" changes?). But, I have to read all the other
dozen+ threads about that topic first.
> + flexarray_append_pair(back, "state", "1");
4.6+ has macros for "state" values, like
flexarray_append_pair(back, "state", GCSPRINTF("%d", XenbusStateInitialising));
> + flexarray_append_pair(front, "state", "1");
4.6+ has macros for "state" values.
> + LOG(DEBUG, "Adding new usb device to xenstore");
Which one? Perhaps print also details.
> + LOG(DEBUG, "Removing USB device from xenstore");
Which one? Perhaps print also details.
> + /* check if the USB interface is already bound to "usbbcak" */
Typo.
Olaf
next prev parent reply other threads:[~2015-11-12 11:32 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 9:08 [PATCH V8 0/7] xen pvusb toolstack work Chunyan Liu
2015-10-21 9:08 ` [PATCH V8 1/7] libxl: export some functions for pvusb use Chunyan Liu
2015-10-27 11:08 ` Juergen Gross
2015-10-21 9:08 ` [PATCH V8 2/7] libxl_read_file_contents: add new entry to read sysfs file Chunyan Liu
2015-10-27 11:31 ` Juergen Gross
2015-11-16 14:03 ` Ian Campbell
2015-11-16 18:15 ` Ian Jackson
2015-10-21 9:08 ` [PATCH V8 3/7] libxl: add pvusb API Chunyan Liu
2015-10-27 11:31 ` Juergen Gross
2015-11-04 6:31 ` Chun Yan Liu
2015-11-05 15:54 ` George Dunlap
2015-11-09 18:11 ` Ian Jackson
2015-11-10 8:41 ` Chun Yan Liu
2015-11-10 17:57 ` George Dunlap
2015-11-10 18:11 ` Ian Jackson
2015-11-11 7:21 ` Chun Yan Liu
2015-11-11 2:37 ` Chun Yan Liu
2015-11-12 17:00 ` Ian Jackson
2015-11-13 2:30 ` Chun Yan Liu
2015-11-16 18:06 ` Ian Jackson
2015-11-17 5:47 ` Chun Yan Liu
2015-11-12 11:32 ` Olaf Hering [this message]
2015-11-13 2:32 ` Chun Yan Liu
2015-11-12 17:27 ` George Dunlap
2015-11-13 2:56 ` Chun Yan Liu
2015-11-13 11:19 ` Olaf Hering
2015-11-16 10:01 ` George Dunlap
2015-11-18 5:48 ` Chun Yan Liu
2015-11-18 9:44 ` Olaf Hering
2015-11-18 10:03 ` Ian Campbell
2015-11-18 10:42 ` Olaf Hering
2015-11-19 1:33 ` Chun Yan Liu
2015-11-19 6:24 ` Chun Yan Liu
2015-11-23 17:24 ` George Dunlap
2015-10-21 9:08 ` [PATCH V8 4/7] libxl: add libxl_device_usb_assignable_list API Chunyan Liu
2015-10-27 11:32 ` Juergen Gross
2015-11-11 16:07 ` George Dunlap
2015-10-21 9:08 ` [PATCH V8 5/7] xl: add pvusb commands Chunyan Liu
2015-10-27 11:37 ` Juergen Gross
2015-11-12 11:38 ` George Dunlap
2015-11-12 11:39 ` George Dunlap
2015-11-13 2:43 ` Chun Yan Liu
2015-11-16 10:05 ` George Dunlap
2015-11-12 14:42 ` Olaf Hering
2015-11-12 14:49 ` George Dunlap
2015-11-13 2:49 ` Chun Yan Liu
2015-10-21 9:08 ` [PATCH V8 6/7] xl: add usb-assignable-list command Chunyan Liu
2015-10-27 11:38 ` Juergen Gross
2015-11-12 11:44 ` George Dunlap
2015-10-21 9:08 ` [PATCH V8 7/7] domcreate: support pvusb in configuration file Chunyan Liu
2015-10-27 11:41 ` Juergen Gross
2015-11-12 16:10 ` George Dunlap
2015-11-13 2:54 ` Chun Yan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112113200.GA302@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=caobosimon@gmail.com \
--cc=cyliu@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jfehlig@suse.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).