From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: correct bug in domain builder regarding page tables for pvh Date: Thu, 19 Nov 2015 16:45:01 +0000 Message-ID: <20151119164501.GA5043@citrix.com> References: <1447949468-18393-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1447949468-18393-1-git-send-email-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On Thu, Nov 19, 2015 at 05:11:08PM +0100, Juergen Gross wrote: > Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of > domain builder's page table handler") dropped a special case for pvh > resulting in page tables being mapped read-only. This led to a panic > of the domain in early boot. > > Correct this error. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu Boris, can you test this as well? > --- > tools/libxc/xc_dom_x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c > index 7279fa2..5ff33ca 100644 > --- a/tools/libxc/xc_dom_x86.c > +++ b/tools/libxc/xc_dom_x86.c > @@ -372,7 +372,7 @@ static x86_pgentry_t get_pg_prot_x86(struct xc_dom_image *dom, int l, > unsigned m; > > prot = domx86->params->lvl_prot[l]; > - if ( l > 0 ) > + if ( l > 0 || dom->pvh_enabled ) > return prot; > > for ( m = 0; m < domx86->n_mappings; m++ ) > -- > 2.6.2 >