* [PATCH] libxl: correct bug in domain builder regarding page tables for pvh
@ 2015-11-19 16:11 Juergen Gross
2015-11-19 16:45 ` Wei Liu
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2015-11-19 16:11 UTC (permalink / raw)
To: xen-devel, Ian.Campbell, ian.jackson, stefano.stabellini,
wei.liu2, boris.ostrovsky
Cc: Juergen Gross
Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of
domain builder's page table handler") dropped a special case for pvh
resulting in page tables being mapped read-only. This led to a panic
of the domain in early boot.
Correct this error.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libxc/xc_dom_x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
index 7279fa2..5ff33ca 100644
--- a/tools/libxc/xc_dom_x86.c
+++ b/tools/libxc/xc_dom_x86.c
@@ -372,7 +372,7 @@ static x86_pgentry_t get_pg_prot_x86(struct xc_dom_image *dom, int l,
unsigned m;
prot = domx86->params->lvl_prot[l];
- if ( l > 0 )
+ if ( l > 0 || dom->pvh_enabled )
return prot;
for ( m = 0; m < domx86->n_mappings; m++ )
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: correct bug in domain builder regarding page tables for pvh
2015-11-19 16:11 [PATCH] libxl: correct bug in domain builder regarding page tables for pvh Juergen Gross
@ 2015-11-19 16:45 ` Wei Liu
2015-11-19 17:41 ` Boris Ostrovsky
0 siblings, 1 reply; 4+ messages in thread
From: Wei Liu @ 2015-11-19 16:45 UTC (permalink / raw)
To: Juergen Gross
Cc: wei.liu2, Ian.Campbell, stefano.stabellini, ian.jackson,
xen-devel, boris.ostrovsky
On Thu, Nov 19, 2015 at 05:11:08PM +0100, Juergen Gross wrote:
> Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of
> domain builder's page table handler") dropped a special case for pvh
> resulting in page tables being mapped read-only. This led to a panic
> of the domain in early boot.
>
> Correct this error.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Boris, can you test this as well?
> ---
> tools/libxc/xc_dom_x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> index 7279fa2..5ff33ca 100644
> --- a/tools/libxc/xc_dom_x86.c
> +++ b/tools/libxc/xc_dom_x86.c
> @@ -372,7 +372,7 @@ static x86_pgentry_t get_pg_prot_x86(struct xc_dom_image *dom, int l,
> unsigned m;
>
> prot = domx86->params->lvl_prot[l];
> - if ( l > 0 )
> + if ( l > 0 || dom->pvh_enabled )
> return prot;
>
> for ( m = 0; m < domx86->n_mappings; m++ )
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: correct bug in domain builder regarding page tables for pvh
2015-11-19 16:45 ` Wei Liu
@ 2015-11-19 17:41 ` Boris Ostrovsky
2015-11-20 14:37 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Boris Ostrovsky @ 2015-11-19 17:41 UTC (permalink / raw)
To: Wei Liu, Juergen Gross
Cc: stefano.stabellini, ian.jackson, Ian.Campbell, xen-devel
On 11/19/2015 11:45 AM, Wei Liu wrote:
> On Thu, Nov 19, 2015 at 05:11:08PM +0100, Juergen Gross wrote:
>> Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of
>> domain builder's page table handler") dropped a special case for pvh
>> resulting in page tables being mapped read-only. This led to a panic
>> of the domain in early boot.
>>
>> Correct this error.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
>
> Boris, can you test this as well?
Yes, it's all good.
-boris
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libxl: correct bug in domain builder regarding page tables for pvh
2015-11-19 17:41 ` Boris Ostrovsky
@ 2015-11-20 14:37 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-11-20 14:37 UTC (permalink / raw)
To: Boris Ostrovsky, Wei Liu, Juergen Gross
Cc: stefano.stabellini, ian.jackson, xen-devel
On Thu, 2015-11-19 at 12:41 -0500, Boris Ostrovsky wrote:
> On 11/19/2015 11:45 AM, Wei Liu wrote:
> > On Thu, Nov 19, 2015 at 05:11:08PM +0100, Juergen Gross wrote:
> > > Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of
> > > domain builder's page table handler") dropped a special case for pvh
> > > resulting in page tables being mapped read-only. This led to a panic
> > > of the domain in early boot.
> > >
> > > Correct this error.
> > >
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Boris, can you test this as well?
>
> Yes, it's all good.
I took this as: Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
and have applied, thanks all.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-20 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-19 16:11 [PATCH] libxl: correct bug in domain builder regarding page tables for pvh Juergen Gross
2015-11-19 16:45 ` Wei Liu
2015-11-19 17:41 ` Boris Ostrovsky
2015-11-20 14:37 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).