From: Wei Liu <wei.liu2@citrix.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen devel <xen-devel@lists.xen.org>,
Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v2 5/5] tools/libxl: remove unused function libxl__domain_save_device_model()
Date: Wed, 6 Jan 2016 14:10:45 +0000 [thread overview]
Message-ID: <20160106141045.GG27789@citrix.com> (raw)
In-Reply-To: <1451959581-14275-6-git-send-email-wency@cn.fujitsu.com>
On Tue, Jan 05, 2016 at 10:06:21AM +0800, Wen Congyang wrote:
> After the commit d77570e7, libxl__domain_save_device_model() can
> be dropped.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
This is incomplete as far as I can tell.
There are several references to the said function:
$ git grep libxl__domain_save_device_model
libxl.c: * On suspend libxl__domain_save_device_model will have already
libxl_dom.c:void libxl__domain_save_device_model(libxl__egc *egc,
libxl_internal.h: /* private for libxl__domain_save_device_model */
libxl_internal.h:_hidden void libxl__domain_save_device_model(libxl__egc *egc,
I think you haven't handled the instances showed up in line 1 and line
3.
Wei.
next prev parent reply other threads:[~2016-01-06 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 2:06 [PATCH v2 0/5] migration/remus: bug fix and cleanup Wen Congyang
2016-01-05 2:06 ` [PATCH v2 1/5] remus: don't call stream_continue() when doing failover Wen Congyang
2016-01-05 2:06 ` [PATCH v2 2/5] remus: don't write xenstore data if it fails Wen Congyang
2016-01-05 9:27 ` Andrew Cooper
2016-01-05 9:35 ` Wen Congyang
2016-01-05 2:06 ` [PATCH v2 3/5] tools/libxc: don't send end record if remus fails Wen Congyang
2016-01-05 2:06 ` [PATCH v2 4/5] tools/libxc: error handling for the postcopy() callback Wen Congyang
2016-01-05 9:18 ` Andrew Cooper
2016-01-05 2:06 ` [PATCH v2 5/5] tools/libxl: remove unused function libxl__domain_save_device_model() Wen Congyang
2016-01-06 14:10 ` Wei Liu [this message]
2016-01-06 15:12 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106141045.GG27789@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=hongyang.yang@easystack.cn \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).