Re: [PATCH 3/4] tools/xl: add a new xl configuration 'nvdimm'

[Haozhong Zhang <haozhong.zhang@intel.com>]

On 01/06/16 05:40, Jan Beulich wrote:
> >>> On 29.12.15 at 12:31, <haozhong.zhang@intel.com> wrote:
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -962,6 +962,25 @@ FIFO-based event channel ABI support up to 131,071 event channels.
> >  Other guests are limited to 4095 (64-bit x86 and ARM) or 1023 (32-bit
> >  x86).
> >  
> > +=item B<nvdimm=[ "NVDIMM_SPEC_STRING", "NVDIMM_SPEC_STRING", ... ]>
> > +
> > +Specifies the NVDIMM devices which are provided to the guest.
> > +
> > +Each B<NVDIMM_SPEC_STRING> is a comma-separated list of C<KEY=VALUE>
> > +settings, from the following list:
> > +
> > +=over 4
> > +
> > +=item C<file=PATH_TO_NVDIMM_DEVICE_FILE>
> > +
> > +Specifies the path to the file of the NVDIMM device, e.g. file=/dev/pmem0.
> > +
> > +=item C<size=MBYTES>
> > +
> > +Specifies the size in Mbytes of the NVDIMM device.
> 
> This looks odd: Either the entire file is meant to be passed (in
> which case the size should be derivable) or you need an
> (offset,size) pair here.
>

It intends to pass the entire file. I'll remove the 'size' option and
derive it either in toolstack or QEMU side.

Haozhong