From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Cc: Juergen Gross <JGross@suse.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 2/5] build: Hook the schedulers into Kconfig
Date: Fri, 8 Jan 2016 12:18:15 -0500 [thread overview]
Message-ID: <20160108171815.GA11492@char.us.oracle.com> (raw)
In-Reply-To: <m2a8og3suf.fsf@Nebula.lan>
On Fri, Jan 08, 2016 at 11:04:56AM -0600, Jonathan Creekmore wrote:
>
> Doug Goldstein writes:
>
> > On 1/8/16 10:49 AM, Jan Beulich wrote:
> >>>>> On 08.01.16 at 17:30, <jonathan.creekmore@gmail.com> wrote:
> >>> So, based on the Kconfig setup and the linker ASSERT, there should be no
> >>> way to have a default scheduler that is not in the build. I wish Kconfig
> >>> allowed you to state that you must have at least one option selected or
> >>> up to all of the options selected (so I could require 1-4 schedulers
> >>> compiled in, but not 0). Unfortunately, the only way that seems allowed
> >>> is if you compile code in as modules, which Xen does not (with a choice
> >>> block, you can select multiple items as M, but only 1 as Y, but at least
> >>> 1 must be present --- since we only support Y, the choice block wouldn't
> >>> work for the schedulers).
> >>
> >> Perhaps credit should just not be configurable then?
> >>
> >> Jan
> >>
> >
> > How much effort are we willing to put in saving someone? We've already
> > got these options completely hidden away. We've already given the user a
> > warning that what they're doing isn't supported and they shouldn't be
> > touching this. Then they have to disable the scheduler that they pick as
> > the default. How many people are we expecting to really do this? I'm all
> > for idiot proofing things but at some point we've got to say there's
> > enough barriers to prevent this from happening. Otherwise we need to put
> > a Xen developer in every Xen users home or office.
>
> At this point, with the (not submitted yet) ASSERT in the linker file,
> it is a compile error to not have any schedulers linked in and Kconfig
> enforces that only schedulers compiled in can be a default.
That would be good!
next prev parent reply other threads:[~2016-01-08 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:29 [PATCH v3 0/5] Allow schedulers to be selectable through Kconfig Jonathan Creekmore
2016-01-07 17:29 ` [PATCH v3 1/5] build: Env var to enable expert config options Jonathan Creekmore
2016-01-08 15:43 ` Konrad Rzeszutek Wilk
2016-01-07 17:29 ` [PATCH v3 2/5] build: Hook the schedulers into Kconfig Jonathan Creekmore
2016-01-08 15:47 ` Konrad Rzeszutek Wilk
2016-01-08 15:54 ` Andrew Cooper
2016-01-08 15:59 ` Dario Faggioli
2016-01-08 16:02 ` Jonathan Creekmore
2016-01-08 16:13 ` Juergen Gross
2016-01-08 16:30 ` Jonathan Creekmore
2016-01-08 16:49 ` Jan Beulich
2016-01-08 16:58 ` Doug Goldstein
2016-01-08 17:04 ` Jonathan Creekmore
2016-01-08 17:13 ` Andrew Cooper
2016-01-08 17:18 ` Konrad Rzeszutek Wilk [this message]
2016-01-11 9:06 ` Jan Beulich
2016-01-08 16:30 ` Jan Beulich
2016-01-07 17:29 ` [PATCH v3 3/5] build: Alloc space for sched list in the link file Jonathan Creekmore
2016-01-08 15:48 ` Konrad Rzeszutek Wilk
2016-01-07 17:29 ` [PATCH v3 4/5] sched: Register the schedulers into the list Jonathan Creekmore
2016-01-08 15:48 ` Konrad Rzeszutek Wilk
2016-01-07 17:29 ` [PATCH v3 5/5] sched: Use the auto-generated list of schedulers Jonathan Creekmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108171815.GA11492@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jonathan.creekmore@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).