From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Andy Whitcroft <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.orgAndrew Cooper <an>
Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 21:29:06 +0200 [thread overview]
Message-ID: <20160110212531-mutt-send-email-mst__38608.2071731382$1452454237$gmane$org@redhat.com> (raw)
In-Reply-To: <1452439051.7773.27.camel@perches.com>
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > > SMP-only barriers were missing in checkpatch.pl
> > >
> > > Refactor code slightly to make adding more variants easier.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > If I use a variable called $smp_barriers, I'd expect
> > it to actually be the smp_barriers, not to have to
> > prefix it with smp_ before using it.
> >
> > my $smp_barriers = qr{
> > smp_store_release|
> > smp_load_acquire|
> > smp_store_mb|
> > smp_read_barrier_depends
>
> That's missing (?:barriers) too.
My version has it but need to add ?: to avoid
a capture group.
> btw: shouldn't this also have
> smp_mb__(?:before|after)_atomic
> ?
Good catch, included in the next version.
--
MST
next prev parent reply other threads:[~2016-01-10 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1452427000-4520-1-git-send-email-mst@redhat.com>
2016-01-10 11:56 ` [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Michael S. Tsirkin
2016-01-10 11:57 ` [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-10 11:57 ` [PATCH v2 3/3] checkpatch: add virt barriers Michael S. Tsirkin
[not found] ` <1452427000-4520-2-git-send-email-mst@redhat.com>
2016-01-10 15:07 ` [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Joe Perches
[not found] ` <1452438425.7773.21.camel@perches.com>
2016-01-10 15:17 ` Joe Perches
2016-01-10 19:13 ` Michael S. Tsirkin
[not found] ` <1452439051.7773.27.camel@perches.com>
2016-01-10 19:29 ` Michael S. Tsirkin [this message]
[not found] ` <1452427000-4520-3-git-send-email-mst@redhat.com>
2016-01-10 15:08 ` [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160110212531-mutt-send-email-mst__38608.2071731382$1452454237$gmane$org@redhat.com' \
--to=mst@redhat.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andreyknvl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.orgAndrew \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).