From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] tools: make flask utils build unconditional Date: Mon, 11 Jan 2016 15:19:33 +0000 Message-ID: <20160111151933.GT26419@citrix.com> References: <1450759603-24249-1-git-send-email-cardoe@cardoe.com> <20160104122805.GG9423@citrix.com> <568A7E3F.9020108@cardoe.com> <20160104142638.GA12639@citrix.com> <1452004651.13361.289.camel@citrix.com> <1452008181.13361.328.camel@citrix.com> <20160105161328.GD27789@citrix.com> <1452011059.13361.363.camel@citrix.com> <20160105164213.GE27789@citrix.com> <569004A3.1080705@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <569004A3.1080705@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein Cc: Wei Liu , Ian Campbell , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org On Fri, Jan 08, 2016 at 12:49:07PM -0600, Doug Goldstein wrote: [...] > Ok so I'm at a loss what steps I need to take. I've submitted patches to > put the config in /boot so that this check can be made but there's a > disagreement if that's even necessary or not. > That's a bit unfortunate. :-( But if I'm not mistaken that's orthogonal to this problem, right? That's one more step down the road regarding grub integration. > Do I need to supply a patch to make --disable-xsmpolicy the default so > that this change doesn't generate the policy by default? The point of > this patch is to compile the necessarily bits always which will help > shake out bugs earlier. If we don't want the policy file to be installed > then we should use the proper setting for that and not the fact that the > utility isn't being compiled. > I think one solution would be to modify flask/Makefile to guard policy compilation against (FLASK_ENABLE && FLASK_POLICY). What do you think? Admittedly I haven't followed closely all the KConfig work so I might be talking nonsense. Ian and Ian? Wei. > -- > Doug Goldstein >