From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, mpohlack@amazon.de, JBeulich@suse.com,
xen-devel@lists.xenproject.org, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor.
Date: Wed, 13 Jan 2016 21:58:29 -0500 [thread overview]
Message-ID: <20160114025826.GA10154@x230.dumpdata.com> (raw)
In-Reply-To: <20160111141223.GP26419@citrix.com>
> > + info->build_id = strdup("");
>
> I guess you're following existing strdup examples in this function.
/me nods.
>
> Since now there is a GC in scope, you can use libxl__strdup. Presumably
> you can also change other instances to use libxl__strdup.
Would you be OK if I did it in another patch? I can make it
part of the series if you would like.
>
> Wei.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-01-14 2:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:25 [PATCH v3] Add build-id to XENVER hypercall Konrad Rzeszutek Wilk
2016-01-08 2:25 ` [PATCH v3 1/3] xsm/xen_version: Add XSM for the xen_version hypercall (v6) Konrad Rzeszutek Wilk
2016-01-08 17:57 ` Daniel De Graaf
2016-01-12 16:08 ` Jan Beulich
2016-01-08 2:25 ` [PATCH v3 2/3] XENVER_build_id: Provide ld-embedded build-ids (v8) Konrad Rzeszutek Wilk
2016-01-12 16:25 ` Jan Beulich
2016-01-12 16:43 ` Konrad Rzeszutek Wilk
2016-01-12 17:00 ` Jan Beulich
2016-01-14 2:02 ` Konrad Rzeszutek Wilk
2016-01-14 8:58 ` Jan Beulich
2016-01-14 9:07 ` Martin Pohlack
2016-01-14 9:14 ` Jan Beulich
2016-01-25 15:16 ` Konrad Rzeszutek Wilk
2016-01-25 16:10 ` Jan Beulich
2016-01-15 21:49 ` Konrad Rzeszutek Wilk
2016-01-18 8:51 ` Jan Beulich
2016-01-19 16:05 ` Konrad Rzeszutek Wilk
2016-01-19 16:36 ` Jan Beulich
2016-01-19 16:47 ` Konrad Rzeszutek Wilk
2016-02-17 11:37 ` Ian Jackson
2016-01-08 2:25 ` [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor Konrad Rzeszutek Wilk
2016-01-11 14:12 ` Wei Liu
2016-01-14 2:58 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114025826.GA10154@x230.dumpdata.com \
--to=konrad@darnok.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mpohlack@amazon.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).