From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor. Date: Wed, 13 Jan 2016 21:58:29 -0500 Message-ID: <20160114025826.GA10154@x230.dumpdata.com> References: <1452219920-14043-1-git-send-email-konrad.wilk@oracle.com> <1452219920-14043-4-git-send-email-konrad.wilk@oracle.com> <20160111141223.GP26419@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aJY7S-0003yA-2C for xen-devel@lists.xenproject.org; Thu, 14 Jan 2016 02:58:38 +0000 Received: from cm5.websitewelcome.com (cm5.websitewelcome.com [192.185.178.233]) by gateway31.websitewelcome.com (Postfix) with ESMTP id A37E8D1EA7DB8 for ; Wed, 13 Jan 2016 20:58:35 -0600 (CST) Content-Disposition: inline In-Reply-To: <20160111141223.GP26419@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.campbell@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, mpohlack@amazon.de, JBeulich@suse.com, xen-devel@lists.xenproject.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org > > + info->build_id = strdup(""); > > I guess you're following existing strdup examples in this function. /me nods. > > Since now there is a GC in scope, you can use libxl__strdup. Presumably > you can also change other instances to use libxl__strdup. Would you be OK if I did it in another patch? I can make it part of the series if you would like. > > Wei. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel