Re: [PATCH v1] xen/arm: Add r1p12 to the list of supported Cadence UARTs

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote:
> On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> 
> Where are the bindings for cdns,uart-r1p12 defined? I don't see it
> mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt in
> mainline Linux.

Hi Ian,

The bindings are currently in our queue:
https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart.txt


> Does the driver need to differ at all compared with what is needed for
> r1p8? Normally if there is no (practical/visible) difference then in DT-
> world there is no need for a new compatible string, since the device is
> still compatible.
> 
> If there are differences in the h/w but they are not relevant to our
> particular driven then please say so in the commit log.

Right, there are SW visible differences (the Linux driver uses them) but
none affecting XEN. I'll note that in the commit message.

Thanks,
Edgar


> 
> Ian.
> 
> > 
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> >  xen/drivers/char/cadence-uart.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-
> > uart.c
> > index 933672f..7f90f8d 100644
> > --- a/xen/drivers/char/cadence-uart.c
> > +++ b/xen/drivers/char/cadence-uart.c
> > @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node
> > *dev, const void *data)
> >  static const struct dt_device_match cuart_dt_match[] __initconst =
> >  {
> >      DT_MATCH_COMPATIBLE("cdns,uart-r1p8"),
> > +    DT_MATCH_COMPATIBLE("cdns,uart-r1p12"),
> >      { /* sentinel */ },
> >  };
> >