From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Edgar E. Iglesias" Subject: Re: [PATCH v1] xen/arm: Add r1p12 to the list of supported Cadence UARTs Date: Fri, 15 Jan 2016 14:30:40 +0100 Message-ID: <20160115133040.GG29396@toto> References: <1452797047-18322-1-git-send-email-edgar.iglesias@gmail.com> <1452861027.32341.90.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1452861027.32341.90.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: edgar.iglesias@xilinx.com, keir@xen.org, ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote: > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > = > Where are the bindings for=A0cdns,uart-r1p12 defined? I don't see it > mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt in > mainline Linux. Hi Ian, The bindings are currently in our queue: https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/b= indings/serial/cdns%2Cuart.txt > Does the driver need to differ at all compared with what is needed for > r1p8? Normally if there is no (practical/visible) difference then in DT- > world there is no need for a new compatible string, since the device is > still compatible. > = > If there are differences in the h/w but they are not relevant to our > particular driven then please say so in the commit log. Right, there are SW visible differences (the Linux driver uses them) but none affecting XEN. I'll note that in the commit message. Thanks, Edgar > = > Ian. > = > > = > > Signed-off-by: Edgar E. Iglesias > > --- > > =A0xen/drivers/char/cadence-uart.c | 1 + > > =A01 file changed, 1 insertion(+) > > = > > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence- > > uart.c > > index 933672f..7f90f8d 100644 > > --- a/xen/drivers/char/cadence-uart.c > > +++ b/xen/drivers/char/cadence-uart.c > > @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node > > *dev, const void *data) > > =A0static const struct dt_device_match cuart_dt_match[] __initconst =3D > > =A0{ > > =A0=A0=A0=A0=A0DT_MATCH_COMPATIBLE("cdns,uart-r1p8"), > > +=A0=A0=A0=A0DT_MATCH_COMPATIBLE("cdns,uart-r1p12"), > > =A0=A0=A0=A0=A0{ /* sentinel */ }, > > =A0}; > > =A0