From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] public/io/netif.h: change semantics of "request-multicast-control" flag Date: Thu, 21 Jan 2016 15:46:14 +0000 Message-ID: <20160121154614.GX1691@citrix.com> References: <1453294249-6346-1-git-send-email-paul.durrant@citrix.com> <1453390176.4320.47.camel@citrix.com> <56A0FACC.7020301@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMHRb-0007ND-3a for xen-devel@lists.xenproject.org; Thu, 21 Jan 2016 15:46:43 +0000 Content-Disposition: inline In-Reply-To: <56A0FACC.7020301@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Wei Liu , Keir Fraser , Ian Campbell , Tim Deegan , Ian Jackson , Paul Durrant , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, Jan 21, 2016 at 04:35:40PM +0100, Roger Pau Monn=E9 wrote: > El 21/01/16 a les 16.29, Ian Campbell ha escrit: > > On Wed, 2016-01-20 at 12:50 +0000, Paul Durrant wrote: > >> My patch b2700877 "move and amend multicast control documentation" > >> clarified use of the multicast control protocol between frontend and > >> backend. However, it transpires that the restrictions that documentati= on > >> placed on the "request-multicast-control" flag make it hard for a > >> frontend to enable 'all multicast' promiscuous mode, in that to do so > >> would require the frontend and backend to disconnect and re-connect. > >> > >> This patch adds a new "feature-dynamic-multicast-control" flag to allow > >> a backend to advertise that it will watch "request-multicast-control" = hence > >> allowing it to be meaningfully modified by the frontend at any time ra= ther > >> than only when the frontend and backend are disconnected. > >> > >> Signed-off-by: Paul Durrant > >> Cc: Ian Campbell > >> Cc: Ian Jackson > >> Cc: Jan Beulich > >> Cc: Keir Fraser > >> Cc: Tim Deegan > > = > > = > > This looks good to me, but also adding Wei (Linux netback + BSD stuff) = and > > Roger (BSD stuff) for their perspective. > > = > > I should probably have done that for the last set of netif.h changes to= o, > > since apart from the nominal maintainers of xen/include/public/io/*.h i= t's > > worth getting input from the maintainers of the consumers. Not sure we = can > > express that very well in MAINTAINERS :-(. > = > I'm going to leave this one to Wei, he has more experience than me > regarding FreeBSD netfront (and xen-net related topics). > = > FWIW, a quick and dirty grep on FreeBSD netfront doesn't show any > results for "request-multicast-control", so I guess it's not implemented. > = No, it is not implemented. Wei. > Roger. > =