From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory Date: Mon, 25 Jan 2016 13:01:20 +0100 Message-ID: <20160125120120.GA23881@gmail.com> References: <1452864168.32341.97.camel@citrix.com> <1452864188-2417-1-git-send-email-ian.campbell@citrix.com> <1452864188-2417-12-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1452864188-2417-12-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Jan 15, Ian Campbell wrote: > libxenforeignmemory will provide a stable API and ABI for mapping > foreign domain memory (subject to appropriate privileges). I think this will break my Xen pkg build: [ 333s] kdd-xen.c: In function 'kdd_access_physical_page': [ 333s] kdd-xen.c:508:15: warning: implicit declaration of function 'xc_map_foreign_range' [-Wimplicit-function-declaration] [ 333s] map = xc_map_foreign_range(g->xc_handle, [ 333s] ^ [ 333s] kdd-xen.c:508:13: warning: assignment makes pointer from integer without a cast [-Wint-conversion] [ 333s] map = xc_map_foreign_range(g->xc_handle, [ 333s] ^ 3272230848f36eb5bbb660216898a90048a81d9f worked, 2e46e3f2539d026594ec1618e7df2c2bc8785b42 would start to fail. Olaf