xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen devel <xen-devel@lists.xen.org>,
	Dong Eddie <eddie.dong@intel.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v5 COLOPre 14/18] tools/libxl: fix backword compatibility after the automatic renaming
Date: Mon, 25 Jan 2016 14:43:46 -0500	[thread overview]
Message-ID: <20160125194346.GT14977@char.us.oracle.com> (raw)
In-Reply-To: <1450338502-27335-15-git-send-email-wency@cn.fujitsu.com>

On Thu, Dec 17, 2015 at 03:48:18PM +0800, Wen Congyang wrote:
> From: Yang Hongyang <hongyang.yang@easystack.cn>
> 
> The error code ERROR_REMUS_XXX was introduced in Xen 4.5, and
> changed to ERROR_CHECKPOINT_XXX after previous renaming.
> The patch fix the backword compatibility.
> 
> Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  tools/libxl/libxl.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 67a4ad7..2a26ba2 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -883,6 +883,19 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, libxl_mac *src);
>   */
>  #define LIBXL_HAVE_CHECKPOINTED_STREAM 1
>  
> +/* Remus stuff */

/sRemus stuff//

.. as it is obvious that this is remus related.
> +/*
> + * ERROR_REMUS_XXX error code only exists from Xen 4.5, and in Xen 4.6

s/4.6/4.7/

> + * it is changed to ERROR_CHECKPOINT_XXX
> + */
> +#if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION >= 0x040500 \
> +                               && LIBXL_API_VERSION < 0x040600

s/040600/040700/

> +#define ERROR_REMUS_DEVOPS_DOES_NOT_MATCH \
> +        ERROR_CHECKPOINT_DEVOPS_DOES_NOT_MATCH
> +#define ERROR_REMUS_DEVICE_NOT_SUPPORTED \
> +        ERROR_CHECKPOINT_DEVICE_NOT_SUPPORTED
> +#endif
> +
>  typedef char **libxl_string_list;
>  void libxl_string_list_dispose(libxl_string_list *sl);
>  int libxl_string_list_length(const libxl_string_list *sl);
> -- 
> 2.5.0
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2016-01-25 19:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  7:48 [PATCH v5 COLOPre 00/18] Prerequisite patches for COLO Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 01/18] libxl/remus: init checkpoint_callback in Remus setup callback Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 02/18] tools/libxl: move remus code into libxl_remus.c Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 03/18] tools/libxl: move save/restore code into libxl_dom_save.c Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 04/18] libxl/save: Refactor libxl__domain_suspend_state Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 05/18] tools/libxc: support to resume uncooperative HVM guests Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 06/18] tools/libxl: introduce enum type libxl_checkpointed_stream Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 07/18] migration/save: pass checkpointed_stream from libxl to libxc Wen Congyang
2016-01-25 18:38   ` Konrad Rzeszutek Wilk
2016-01-25 19:14     ` Konrad Rzeszutek Wilk
2016-01-26  5:42       ` Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 08/18] tools/libxl: introduce libxl__domain_restore_device_model to load qemu state Wen Congyang
2016-01-25 18:41   ` Konrad Rzeszutek Wilk
2016-01-26  6:17     ` Wen Congyang
2016-01-26 15:02       ` Konrad Rzeszutek Wilk
2015-12-17  7:48 ` [PATCH v5 COLOPre 09/18] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 10/18] tools/libxl: export logdirty_init Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 11/18] tools/libxl: Add back channel to allow migration target send data back Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 12/18] tools/libx{l, c}: add back channel to libxc Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 13/18] tools/libxl: rename remus device to checkpoint device Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 14/18] tools/libxl: fix backword compatibility after the automatic renaming Wen Congyang
2016-01-25 19:43   ` Konrad Rzeszutek Wilk [this message]
2016-01-26  8:06     ` Wen Congyang
2016-01-26 15:02       ` Konrad Rzeszutek Wilk
2015-12-17  7:48 ` [PATCH v5 COLOPre 15/18] tools/libxl: adjust the indentation Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 16/18] tools/libxl: store remus_ops in checkpoint device state Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 17/18] tools/libxl: move remus state into a seperate structure Wen Congyang
2015-12-17  7:48 ` [PATCH v5 COLOPre 18/18] tools/libxl: seperate device init/cleanup from checkpoint device layer Wen Congyang
2016-01-04 17:02 ` [PATCH v5 COLOPre 00/18] Prerequisite patches for COLO Ian Jackson
2016-01-18  1:51   ` Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160125194346.GT14977@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).