From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v5 COLOPre 08/18] tools/libxl: introduce
 libxl__domain_restore_device_model to load qemu state
Date: Tue, 26 Jan 2016 10:02:24 -0500
Message-ID: <20160126150224.GJ19666@char.us.oracle.com>
References: <1450338502-27335-1-git-send-email-wency@cn.fujitsu.com>
	<1450338502-27335-9-git-send-email-wency@cn.fujitsu.com>
	<20160125184100.GN14977@char.us.oracle.com>
	<56A70F64.50104@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <56A70F64.50104@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen devel <xen-devel@lists.xen.org>, Shriram Rajagopalan <rshriram@cs.ubc.ca>, Dong Eddie <eddie.dong@intel.com>, Gui Jianfeng <guijianfeng@cn.fujitsu.com>, Anthony Perard <anthony.perard@citrix.com>, Yang Hongyang <hongyang.yang@easystack.cn>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jan 26, 2016 at 02:17:08PM +0800, Wen Congyang wrote:
> On 01/26/2016 02:41 AM, Konrad Rzeszutek Wilk wrote:
> > On Thu, Dec 17, 2015 at 03:48:12PM +0800, Wen Congyang wrote:
> >> From: Yang Hongyang <hongyang.yang@easystack.cn>
> >>
> >> In normal migration, the qemu state was passed to qemu as a parameter.
> > 
> > /was/is/
> > 
> >> With COLO, Secondary vm is running. So we will do the following steps
> >> at every checkpoint:
> >> 1. suspend both primary vm and secondary vm
> >> 2. sync the state
> >> 3. resume both primary vm and secondary vm
> >> Primary will send qemu's state in step2, and
> >> Secondary's qemu should read it and restore the state before it
> > 
> > s/Secondary/secondary/
> >> is resumed. We can not pass the state to qemu as a parameter because
> >> Secondary QEMU already started at this point, so we introduce
> > 
> > s/Secondary/secondary/
> >> libxl__domain_restore_device_model() to do it.
> >> This API should be called before resuming secondary vm.
> > 
> > s/before/MUST/
> 
> s/should/MUST/?

<sigh> Yes. Thank you!