From: Tim Deegan <tim@xen.org>
To: "Han, Huaitong" <huaitong.han@intel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>,
"george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"keir@xen.org" <keir@xen.org>
Subject: Re: [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn
Date: Wed, 27 Jan 2016 09:34:17 +0000 [thread overview]
Message-ID: <20160127093417.GA38759@deinos.phlegethon.org> (raw)
In-Reply-To: <1453879352.4038.12.camel@intel.com>
Hi,
At 07:22 +0000 on 27 Jan (1453879344), Han, Huaitong wrote:
> On Tue, 2016-01-26 at 14:30 +0000, Tim Deegan wrote:
> > This seems OK. But can you please:
> > - Add this new adjustment once, in paging_gva_to_gfn(), instead of
> > adding it to each implementation; and
> > - Adjust the comment above the declaration of paging_gva_to_gfn() in
> > paging.h to describe this new behaviour.
> Although adding adjustment in paging_gva_to_gfn can reduce code
> duplication, adding it to each implementation is more readable, becasue
> other sections of pfec are handled in each implementation.
True, but since paging_gva_to_gfn() is already non-trivial and this
is a different kind of adjustment, I'd still like it done there.
I'll leave this to George's discretion as x86/mm maintainer.
But in any case, please add the comment describing the new semantics.
Cheers,
Tim.
next prev parent reply other threads:[~2016-01-27 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 7:30 [PATCH V6 0/5] x86/hvm: pkeys, add memory protection-key support Huaitong Han
2016-01-19 7:30 ` [PATCH V6 1/5] x86/hvm: pkeys, disable pkeys for guests in non-paging mode Huaitong Han
2016-01-19 7:30 ` [PATCH V6 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables Huaitong Han
2016-01-25 15:46 ` Jan Beulich
2016-01-27 3:18 ` Han, Huaitong
2016-01-27 10:20 ` Jan Beulich
2016-01-19 7:30 ` [PATCH V6 3/5] x86/hvm: pkeys, add xstate support for pkeys Huaitong Han
2016-01-25 15:48 ` Jan Beulich
2016-01-19 7:30 ` [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn Huaitong Han
2016-01-25 15:56 ` Jan Beulich
2016-01-26 14:30 ` Tim Deegan
2016-01-27 7:22 ` Han, Huaitong
2016-01-27 9:34 ` Tim Deegan [this message]
2016-01-27 10:13 ` Han, Huaitong
2016-01-19 7:30 ` [PATCH V6 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling Huaitong Han
2016-01-19 9:19 ` Wei Liu
2016-01-25 16:04 ` Jan Beulich
2016-01-25 15:25 ` [PATCH V6 0/5] x86/hvm: pkeys, add memory protection-key support Jan Beulich
2016-01-26 8:06 ` Han, Huaitong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127093417.GA38759@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=huaitong.han@intel.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).