From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn Date: Wed, 27 Jan 2016 09:34:17 +0000 Message-ID: <20160127093417.GA38759@deinos.phlegethon.org> References: <1453188659-8908-1-git-send-email-huaitong.han@intel.com> <1453188659-8908-5-git-send-email-huaitong.han@intel.com> <20160126143002.GB24854@deinos.phlegethon.org> <1453879352.4038.12.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1453879352.4038.12.camel@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Han, Huaitong" Cc: "wei.liu2@citrix.com" , "george.dunlap@eu.citrix.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "xen-devel@lists.xen.org" , "jbeulich@suse.com" , "keir@xen.org" List-Id: xen-devel@lists.xenproject.org Hi, At 07:22 +0000 on 27 Jan (1453879344), Han, Huaitong wrote: > On Tue, 2016-01-26 at 14:30 +0000, Tim Deegan wrote: > > This seems OK. But can you please: > > - Add this new adjustment once, in paging_gva_to_gfn(), instead of > > adding it to each implementation; and > > - Adjust the comment above the declaration of paging_gva_to_gfn() in > > paging.h to describe this new behaviour. > Although adding adjustment in paging_gva_to_gfn can reduce code > duplication, adding it to each implementation is more readable, becasue > other sections of pfec are handled in each implementation. True, but since paging_gva_to_gfn() is already non-trivial and this is a different kind of adjustment, I'd still like it done there. I'll leave this to George's discretion as x86/mm maintainer. But in any case, please add the comment describing the new semantics. Cheers, Tim.