xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH RFC] Remove PV superpage support (v1).
Date: Fri, 29 Jan 2016 11:26:49 -0500	[thread overview]
Message-ID: <20160129162649.GB22787@char.us.oracle.com> (raw)
In-Reply-To: <56AB9A9F02000078000CC756@prv-mh.provo.novell.com>

On Fri, Jan 29, 2016 at 09:00:15AM -0700, Jan Beulich wrote:
> >>> On 29.01.16 at 16:30, <konrad.wilk@oracle.com> wrote:
> > I am hoping the maintainers can guide me in how they would like:
> >  - Deal with documentation? I removed the allowsuperpage from documentation
> >    but perhaps it should just mention deprecated?
> 
> Since you delete the option, deleting it from doc seems fine to me.
> 
> >  - I left put_superpage as put_page_from_l2e calls it - but I can't see
> >    how the _PAGE_PSE bit would be set as you won't be able to even
> >    put that bit on (after my patch). Perhaps just make it an
> >    ASSERT in put_page_from_l2e?
> 
> No, that can't be done. Did you check why it is the way it is
> (having to do with the alternative initial P2M placement, which
> does use superpages despite the guest itself not being able to
> create any)?

If I recall - this was done for P2M array when put in a different virtual
address space? And this being only the initial domain - would this ..
Oh this can be done for normal guests as well I presume?

Time to dig in this a bit more.

> Jan
> 

  reply	other threads:[~2016-01-29 16:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 15:30 [PATCH RFC] Remove PV superpage support (v1) Konrad Rzeszutek Wilk
2016-01-29 15:30 ` [PATCH RFC] xen/libxl/libxl: RIP PV superpage Konrad Rzeszutek Wilk
2016-01-29 16:15   ` Jan Beulich
2016-02-01 10:37   ` Wei Liu
2016-01-29 16:00 ` [PATCH RFC] Remove PV superpage support (v1) Jan Beulich
2016-01-29 16:26   ` Konrad Rzeszutek Wilk [this message]
2016-01-29 16:46     ` Jan Beulich
2016-02-01  4:54       ` Juergen Gross
2016-02-01  7:53         ` Jan Beulich
     [not found]         ` <56AF1D0C02000078000CCBC0@suse.com>
2016-02-01  8:03           ` Juergen Gross
2016-02-01  8:07             ` Jan Beulich
2016-02-01  9:52 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129162649.GB22787@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).