From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH RFC] Remove PV superpage support (v1). Date: Fri, 29 Jan 2016 11:26:49 -0500 Message-ID: <20160129162649.GB22787@char.us.oracle.com> References: <1454081446-9753-1-git-send-email-konrad.wilk@oracle.com> <56AB9A9F02000078000CC756@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <56AB9A9F02000078000CC756@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei Liu , Ian Campbell , Stefano Stabellini , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On Fri, Jan 29, 2016 at 09:00:15AM -0700, Jan Beulich wrote: > >>> On 29.01.16 at 16:30, wrote: > > I am hoping the maintainers can guide me in how they would like: > > - Deal with documentation? I removed the allowsuperpage from documentation > > but perhaps it should just mention deprecated? > > Since you delete the option, deleting it from doc seems fine to me. > > > - I left put_superpage as put_page_from_l2e calls it - but I can't see > > how the _PAGE_PSE bit would be set as you won't be able to even > > put that bit on (after my patch). Perhaps just make it an > > ASSERT in put_page_from_l2e? > > No, that can't be done. Did you check why it is the way it is > (having to do with the alternative initial P2M placement, which > does use superpages despite the guest itself not being able to > create any)? If I recall - this was done for P2M array when put in a different virtual address space? And this being only the initial domain - would this .. Oh this can be done for normal guests as well I presume? Time to dig in this a bit more. > Jan >