From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] xl: don't free additional memory on soft reset Date: Mon, 1 Feb 2016 10:39:10 +0000 Message-ID: <20160201103910.GP25660@citrix.com> References: <1453978705-13504-1-git-send-email-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1453978705-13504-1-git-send-email-vkuznets@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vitaly Kuznetsov Cc: Wei Liu , Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Jan 28, 2016 at 11:58:25AM +0100, Vitaly Kuznetsov wrote: > We don't need to free anything extra from Dom0 in order to perform soft > reset. It can also fail soft reset if it happens that we don't have this > memory (which we don't need) available. > > Signed-off-by: Vitaly Kuznetsov Acked-by: Wei Liu > --- > tools/libxl/xl_cmdimpl.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 25507c7..20704d2 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -2867,11 +2867,13 @@ start: > if (rc < 0) > goto error_out; > > - ret = freemem(domid, &d_config.b_info); > - if (ret < 0) { > - fprintf(stderr, "failed to free memory for the domain\n"); > - ret = ERROR_FAIL; > - goto error_out; > + if (domid_soft_reset == INVALID_DOMID) { > + ret = freemem(domid, &d_config.b_info); > + if (ret < 0) { > + fprintf(stderr, "failed to free memory for the domain\n"); > + ret = ERROR_FAIL; > + goto error_out; > + } > } > > libxl_asyncprogress_how autoconnect_console_how_buf; > -- > 2.5.0 >