From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan.Robinson@ts.fujitsu.com (Alan Robinson) Subject: Re: [PATCH] xen: recalculate per-cpupool credits when updating timeslice Date: Tue, 2 Feb 2016 08:55:11 +0100 Message-ID: <20160202075511.GA23968@ts.fujitsu.com> References: <1454062908-32013-1-git-send-email-jgross@suse.com> Reply-To: Alan.Robinson@ts.fujitsu.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1454062908-32013-1-git-send-email-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross Cc: "george.dunlap@eu.citrix.com" , "dario.faggioli@citrix.com" , "jbeulich@suse.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, Jan 29, 2016 at 11:21:48AM +0100, Juergen Gross wrote: > When modifying the timeslice of the credit scheduler in a cpupool the > cpupool global credit value (n_cpus * credits_per_tslice) isn't > recalculated. This will lead to wrong scheduling decisions later. > > Do the recalculation when updating the timeslice. > > Signed-off-by: Juergen Gross We had notice that the quota's were not working after the timeslice was changed in a mono-cpupool running two guests doing 'for loops'. Applied Juergen's patch to a SuSE xen-4.4.3_02-26.2 rpm, the patch was offset by 6 lines. The guests now observe the quotas when the timeslice is changed. Tested-by: Alan.Robinson -- Sent from my Fujitsu Primergy RXI300 IA64 Firmenangaben: Fujitsu Technology Solutions GmbH / ts.fujitsu.com/imprint