From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [RFC] support more qdisk types Date: Wed, 3 Feb 2016 11:08:14 +0000 Message-ID: <20160203110814.GI23178@citrix.com> References: <56A6BCDE.6040900@suse.com> <20160202145930.GB25660@citrix.com> <56B12849.2010705@suse.com> <20160203103553.GE23178@citrix.com> <1454496687.25207.57.camel@citrix.com> <20160203105525.GH23178@citrix.com> <1454497504.25207.63.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1454497504.25207.63.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Jim Fehlig , Ken Johnson , Wei Liu , xen-devel List-Id: xen-devel@lists.xenproject.org On Wed, Feb 03, 2016 at 11:05:04AM +0000, Ian Campbell wrote: > On Wed, 2016-02-03 at 10:55 +0000, Wei Liu wrote: > > On Wed, Feb 03, 2016 at 10:51:27AM +0000, Ian Campbell wrote: > > > On Wed, 2016-02-03 at 10:35 +0000, Wei Liu wrote: > > > > > Ok. So in your opinion, even if any new disk config is encoded in > > > > > 'target=3D', > > > > > libxlu should split that up into (new) members of > > > > > libxl_device_disk, not just > > > > > plop it into libxl_device_disk.pdev_path? > > > > > = > > > > = > > > > No, not necessarily. I didn't look closely in the code yesterday wh= en > > > > replying, sorry. > > > > = > > > > If=A0=A0target=3D has always been shoveled into pdev_path, using th= at would > > > > be > > > > fine. We already have mechanism to parse target=3D outside of libxl= in > > > > hotplug script. > > > > = > > > > Are you aware of all those hotplug scripts living under tools/hotpl= ug > > > > ? > > > > Does using hotplug script sound plausible to you? > > > > = > > > > Currently hotplug script for QEMU is broken and needs fixing though, > > > > but > > > > I'm sure we can figure it out. > > > = > > > How do hotplug scripts factor into this? > > > = > > = > > If supporting all such block devices=A0=A0requires presenting a block d= evice > > to QEMU? If QEMU directly handles them then hotplug script is not in the > > picture. > = > Perhaps I've misunderstood what this thread is about. I thought it was > about exposing all the various backends which qdisk supports natively, li= ke > CEPH, sheepdog, iscsi, nbd etc. > = Good point. It is me who is confused. Hotplug is not in the picture then. Wei. > Ian.