From: Wei Liu <wei.liu2@citrix.com>
To: Huaitong Han <huaitong.han@intel.com>
Cc: keir@xen.org, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com,
andrew.cooper3@citrix.com, tim@xen.org, xen-devel@lists.xen.org,
jbeulich@suse.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH V9 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling
Date: Wed, 3 Feb 2016 15:02:07 +0000 [thread overview]
Message-ID: <20160203150207.GI10990@citrix.com> (raw)
In-Reply-To: <1454508725-22786-6-git-send-email-huaitong.han@intel.com>
On Wed, Feb 03, 2016 at 10:12:05PM +0800, Huaitong Han wrote:
> This patch adds pkeys support for cpuid handing.
>
> Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is
> CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of CR4.PKE.
>
> X86_FEATURE_OSXSAVE depends on guest X86_FEATURE_XSAVE, but cpu_has_xsave
> function reflects hypervisor X86_FEATURE_XSAVE, it is fixed too.
>
> Signed-off-by: Huaitong Han <huaitong.han@intel.com>
As far as I can tell changes to libxc are in line with overall coding
style and convention in that file. I'm happy to give my ack on this
patch if hypervisor maintainers are happy about the changes.
There is one nit below.
[...]
> - /* Don't expose PCOMMIT to hvm when VMX support is not available */
> + /* Don't expose PCOMMIT to hvm when VMX support is not available. */
White space only change. This should not be included here.
> if ( !cpu_has_vmx_pcommit )
> *ebx &= ~cpufeat_mask(X86_FEATURE_PCOMMIT);
> }
> --
> 2.4.3
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-03 15:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 14:12 [PATCH V9 0/5] x86/hvm: pkeys, add memory protection-key support Huaitong Han
2016-02-03 14:12 ` [PATCH V9 1/5] x86/hvm: pkeys, disable pkeys for guests in non-paging mode Huaitong Han
2016-02-03 15:19 ` Jan Beulich
2016-02-03 15:54 ` Han, Huaitong
2016-02-03 16:01 ` Jan Beulich
2016-02-04 4:57 ` Tian, Kevin
2016-02-03 14:12 ` [PATCH V9 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables Huaitong Han
2016-02-04 5:46 ` Tian, Kevin
2016-02-03 14:12 ` [PATCH V9 3/5] x86/hvm: pkeys, add xstate support for pkeys Huaitong Han
2016-02-04 5:47 ` Tian, Kevin
2016-02-03 14:12 ` [PATCH V9 4/5] xen/mm: Clean up pfec handling in gva_to_gfn Huaitong Han
2016-02-03 15:57 ` Tim Deegan
2016-02-03 14:12 ` [PATCH V9 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling Huaitong Han
2016-02-03 15:02 ` Wei Liu [this message]
2016-02-03 15:06 ` Wei Liu
2016-02-03 15:18 ` Jan Beulich
2016-02-04 4:56 ` [PATCH V9 0/5] x86/hvm: pkeys, add memory protection-key support Tian, Kevin
2016-02-04 5:20 ` Han, Huaitong
2016-02-04 5:25 ` Han, Huaitong
2016-02-04 5:35 ` Tian, Kevin
2016-02-04 8:28 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203150207.GI10990@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=huaitong.han@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).