From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V9 5/5] x86/hvm: pkeys,
 add pkeys support for cpuid handling
Date: Wed, 3 Feb 2016 15:06:22 +0000
Message-ID: <20160203150622.GO23178@citrix.com>
References: <1454508725-22786-1-git-send-email-huaitong.han@intel.com>
	<1454508725-22786-6-git-send-email-huaitong.han@intel.com>
	<20160203150207.GI10990@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20160203150207.GI10990@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Huaitong Han <huaitong.han@intel.com>
Cc: keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, xen-devel@lists.xen.org, jbeulich@suse.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, Feb 03, 2016 at 03:02:07PM +0000, Wei Liu wrote:
> On Wed, Feb 03, 2016 at 10:12:05PM +0800, Huaitong Han wrote:
> > This patch adds pkeys support for cpuid handing.
> > 
> > Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is
> > CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of CR4.PKE.
> > 
> > X86_FEATURE_OSXSAVE depends on guest X86_FEATURE_XSAVE, but cpu_has_xsave
> > function reflects hypervisor X86_FEATURE_XSAVE, it is fixed too.
> > 
> > Signed-off-by: Huaitong Han <huaitong.han@intel.com>
> 
> As far as I can tell changes to libxc are in line with overall coding
> style and convention in that file.  I'm happy to give my ack on this
> patch if hypervisor maintainers are happy about the changes.
> 
> There is one nit below.
> [...]
> > -            /* Don't expose PCOMMIT to hvm when VMX support is not available */
> > +            /* Don't expose PCOMMIT to hvm when VMX support is not available. */
> 
> White space only change. This should not be included here.
> 

Actually it's not white space change. Ignore my comment please.

> >              if ( !cpu_has_vmx_pcommit )
> >                  *ebx &= ~cpufeat_mask(X86_FEATURE_PCOMMIT);
> >          }
> > -- 
> > 2.4.3
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel