From: Wei Liu <wei.liu2@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, wei.liu2@citrix.com, roger.pau@citrix.com
Subject: Re: [PATCH] docs: Specify VCPU hotplug procedure for HVMlite guests
Date: Wed, 3 Feb 2016 16:20:03 +0000 [thread overview]
Message-ID: <20160203162003.GP23178@citrix.com> (raw)
In-Reply-To: <1454515899-1787-1-git-send-email-boris.ostrovsky@oracle.com>
On Wed, Feb 03, 2016 at 11:11:39AM -0500, Boris Ostrovsky wrote:
> HVMlite VCPUs can be added and removed by toggling 'availability'
> value of VCPU's xenstore entry.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
>
> I am not sure this is really needed since it's no different from how we
> do hotplug for PV or HVM/qemu-trad guests.
>
There is no harm to have more document. Not everyone who wants to
implement PVH support is familiar with PV and / or want to look at Linux
and libxl code (for various reasons). ;-)
Wei.
> I may have been a bit too grandiose by describing yesterday's patch as
> "add CPU hotplug support". It was really enabling existing functionality.
>
> docs/misc/hvmlite.markdown | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/misc/hvmlite.markdown b/docs/misc/hvmlite.markdown
> index c1b75c6..1a2e866 100644
> --- a/docs/misc/hvmlite.markdown
> +++ b/docs/misc/hvmlite.markdown
> @@ -80,3 +80,8 @@ are used in order to bring up secondary vCPUs:
> * `VCPUOP_down` is used to bring down a vCPU.
>
> * `VCPUOP_is_up` is used to scan the number of available vCPUs.
> +
> +## VCPU hotplug ##
> +
> +VCPUs can be hot-plugged or hot-removed by writing "online" or "offline" to
> +xenstore's /local/domain/<domain_id>/cpu/<vcpu_id>/availability entry
> --
> 2.1.0
>
prev parent reply other threads:[~2016-02-03 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 16:11 [PATCH] docs: Specify VCPU hotplug procedure for HVMlite guests Boris Ostrovsky
2016-02-03 16:20 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203162003.GP23178@citrix.com \
--to=wei.liu2@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).