Re: [PATCH 3/5] libxl: add support for vscsi

[Olaf Hering <olaf@aepfle.de>]

On Wed, Feb 03, Wei Liu wrote:

> If it is to be removed, why don't you just filter it out and not have it
> in JSON at all? This is provided libxl won't rely on that to do proper
> clean-up I don't see the value of retaining them, and if libxl is
> relying on the JSON file to do clean-up the design is probably wrong.

In its current state my patch will skip a vscsidev in state 5+6 when
collecting the various vscsi-devs/dev-N on a vscsictrl.

However right now its not entirely clear to me if that is correct.
During scsi-attach the vscsidevs get added to JSON, but scsi-detach will
not remove them from JSON. Thats just like ordinary devices. At what
point must the JSON be synced with xenstore? I think at 'xl save/ migrate'.

I think I have to revisit this once I sent out the current state of my
patches, which will not be before Friday this week.

Olaf