From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 3/5] libxl: add support for vscsi Date: Wed, 3 Feb 2016 17:24:29 +0100 Message-ID: <20160203162429.GA13023@aepfle.de> References: <1447415999-22003-1-git-send-email-olaf@aepfle.de> <1447415999-22003-4-git-send-email-olaf@aepfle.de> <20160127100012.GA6631@gmail.com> <20160203143603.GL23178@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160203143603.GL23178@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Feb 03, Wei Liu wrote: > If it is to be removed, why don't you just filter it out and not have it > in JSON at all? This is provided libxl won't rely on that to do proper > clean-up I don't see the value of retaining them, and if libxl is > relying on the JSON file to do clean-up the design is probably wrong. In its current state my patch will skip a vscsidev in state 5+6 when collecting the various vscsi-devs/dev-N on a vscsictrl. However right now its not entirely clear to me if that is correct. During scsi-attach the vscsidevs get added to JSON, but scsi-detach will not remove them from JSON. Thats just like ordinary devices. At what point must the JSON be synced with xenstore? I think at 'xl save/ migrate'. I think I have to revisit this once I sent out the current state of my patches, which will not be before Friday this week. Olaf