From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v7 09/18] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Date: Wed, 3 Feb 2016 19:40:26 +0000 Message-ID: <20160203194026.GY23178@citrix.com> References: <1454045254-3711-1-git-send-email-wency@cn.fujitsu.com> <1454045254-3711-10-git-send-email-wency@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1454045254-3711-10-git-send-email-wency@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wen Congyang Cc: Lars Kurth , Changlong Xie , Wei Liu , Ian Campbell , Andrew Cooper , Jiang Yunhong , Ian Jackson , xen devel , Dong Eddie , Gui Jianfeng , Shriram Rajagopalan , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Fri, Jan 29, 2016 at 01:27:25PM +0800, Wen Congyang wrote: > Secondary vm is running in COLO mode, we need to send secondary > vm's dirty page information to primary host at checkpoint, so we > have to enable qemu logdirty on secondary. > > libxl__domain_suspend_common_switch_qemu_logdirty() is to enable > qemu logdirty. But it uses libxl__domain_save_state, and calls > libxl__xc_domain_saverestore_async_callback_done() before exits. > This can not be used for secondary vm. > > Update libxl__domain_suspend_common_switch_qemu_logdirty() to > introduce a new API libxl__domain_common_switch_qemu_logdirty(). > This API only uses libxl__logdirty_switch, and calls > lds->callback before exits. This new API will be used by the patch: > secondary vm suspend/resume/checkpoint code > > Signed-off-by: Yang Hongyang > Signed-off-by: Wen Congyang > CC: Andrew Cooper > Acked-by: Ian Campbell Acked-by: Wei Liu