From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v7 11/18] tools/libxl: Add back channel to
 allow migration target send data back
Date: Wed, 3 Feb 2016 19:40:41 +0000
Message-ID: <20160203194041.GA23178@citrix.com>
References: <1454045254-3711-1-git-send-email-wency@cn.fujitsu.com>
	<1454045254-3711-12-git-send-email-wency@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1454045254-3711-12-git-send-email-wency@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Lars Kurth <lars.kurth@citrix.com>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen devel <xen-devel@lists.xen.org>, Dong Eddie <eddie.dong@intel.com>, Gui Jianfeng <guijianfeng@cn.fujitsu.com>, Shriram Rajagopalan <rshriram@cs.ubc.ca>, Yang Hongyang <hongyang.yang@easystack.cn>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jan 29, 2016 at 01:27:27PM +0800, Wen Congyang wrote:
> In COLO mode, secondary needs to send the following data to primary:
> 1. In libxl
>    Secondary sends the following CHECKPOINT_CONTEXT to primary:
>    CHECKPOINT_SVM_SUSPENDED, CHECKPOINT_SVM_READY and CHECKPOINT_SVM_RESUMED
> 2. In libxc
>    Secondary sends the dirty pfn list to primary
> 
> But the io_fd only can be written in primary, and only can be read in
> secondary. Save recv_fd in domain_suspend_state, and send_fd in
> domain_create_state. Extend libxl_domain_create_restore API, add a
> send_fd param to it. Add LIBXL_HAVE_CREATE_RESTORE_SEND_FD to indicate
> the API change.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
> ---
>  tools/libxl/libxl.c                  |  2 +-
>  tools/libxl/libxl.h                  | 30 ++++++++++++++++++++++++++++--
>  tools/libxl/libxl_create.c           |  9 +++++----
>  tools/libxl/libxl_internal.h         |  2 ++
>  tools/libxl/xl_cmdimpl.c             |  8 +++++++-
>  tools/ocaml/libs/xl/xenlight_stubs.c |  2 +-
>  6 files changed, 44 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index fc7844d..e286329 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -871,7 +871,7 @@ int libxl_domain_remus_start(libxl_ctx *ctx, libxl_domain_remus_info *info,

The TODO before this function can also be deleted now.

This patch is mostly about stashing the recv_fd. Assuming that is going
to be used later:

Acked-by: Wei Liu <wei.liu2@citrix.com>