From mboxrd@z Thu Jan  1 00:00:00 1970
From: Haozhong Zhang <haozhong.zhang@intel.com>
Subject: Re: [RFC Design Doc] Add vNVDIMM support for Xen
Date: Thu, 4 Feb 2016 10:55:26 +0800
Message-ID: <20160204025526.GA3504@hz-desktop.sh.intel.com>
References: <20160201054414.GA25211@hz-desktop.sh.intel.com>
	<alpine.DEB.2.02.1602021645210.29714@kaball.uk.xensource.com>
	<20160203070052.GA4248@hz-desktop.sh.intel.com>
	<alpine.DEB.2.02.1602031137380.16539@kaball.uk.xensource.com>
	<56B219D4.9030507@citrix.com>
	<alpine.DEB.2.02.1602031522000.16539@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1602031522000.16539@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Juergen Gross <jgross@suse.com>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Jun Nakajima <jun.nakajima@intel.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 02/03/16 15:22, Stefano Stabellini wrote:
> On Wed, 3 Feb 2016, George Dunlap wrote:
> > On 03/02/16 12:02, Stefano Stabellini wrote:
> > > On Wed, 3 Feb 2016, Haozhong Zhang wrote:
> > >> Or, we can make a file system on /dev/pmem0, create files on it, set
> > >> the owner of those files to xen-qemuuser-domid$domid, and then pass
> > >> those files to QEMU. In this way, non-root QEMU should be able to
> > >> mmap those files.
> > >
> > > Maybe that would work. Worth adding it to the design, I would like to
> > > read more details on it.
> > >
> > > Also note that QEMU initially runs as root but drops privileges to
> > > xen-qemuuser-domid$domid before the guest is started. Initially QEMU
> > > *could* mmap /dev/pmem0 while is still running as root, but then it
> > > wouldn't work for any devices that need to be mmap'ed at run time
> > > (hotplug scenario).
> >
> > This is basically the same problem we have for a bunch of other things,
> > right?  Having xl open a file and then pass it via qmp to qemu should
> > work in theory, right?
>
> Is there one /dev/pmem? per assignable region?

Yes.

BTW, I'm wondering whether and how non-root qemu works with xl disk
configuration that is going to access a host block device, e.g.
     disk = [ '/dev/sdb,,hda' ]
If that works with non-root qemu, I may take the similar solution for
pmem.

Thanks,
Haozhong

> Otherwise it wouldn't be safe.