From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v7 3/5] libxl: add support for vscsi
Date: Fri, 5 Feb 2016 11:26:12 +0100 [thread overview]
Message-ID: <20160205102612.GA24678@aepfle.de> (raw)
In-Reply-To: <1454667175-24282-4-git-send-email-olaf@aepfle.de>
On Fri, Feb 05, Olaf Hering wrote:
> @@ -6799,6 +7375,8 @@ int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid,
>
> MERGE(nic, nics, COMPARE_DEVID, {});
>
> + MERGE(vscsictrl, vscsictrls, COMPARE_VSCSI, {});
I think the actual "merge" should be like this, to copy the data
gathered from xenstore into the d_config which was built from JSON.
{
libxl_device_vscsictrl_dispose(dst);
libxl_device_vscsictrl_copy(CTX, dst, src);
}
Olaf
next prev parent reply other threads:[~2016-02-05 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 10:12 [PATCH v7 0/5] libbxl: add support for pvscsi, iteration 7 Olaf Hering
2016-02-05 10:12 ` [PATCH v7 1/5] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2016-02-05 10:12 ` [PATCH v7 2/5] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2016-02-05 10:12 ` [PATCH v7 3/5] libxl: add support for vscsi Olaf Hering
2016-02-05 10:26 ` Olaf Hering [this message]
2016-02-08 11:44 ` Olaf Hering
2016-02-11 15:00 ` Olaf Hering
2016-02-11 15:03 ` Olaf Hering
2016-02-05 10:12 ` [PATCH v7 4/5] vscsiif.h: add some notes about xenstore layout Olaf Hering
2016-02-05 10:12 ` [PATCH v7 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205102612.GA24678@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).