From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 01/13] xsplice: Design document (v5).
Date: Fri, 5 Feb 2016 13:27:37 -0500
Message-ID: <20160205182727.GA26294@x230.dumpdata.com>
References: <1452808031-706-1-git-send-email-konrad.wilk@oracle.com>
	<1452808031-706-2-git-send-email-konrad.wilk@oracle.com>
	<569E48AF.3010000@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1aRl6o-0003MW-3r
	for xen-devel@lists.xenproject.org; Fri, 05 Feb 2016 18:27:54 +0000
Content-Disposition: inline
In-Reply-To: <569E48AF.3010000@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, mpohlack@amazon.com, stefano.stabellini@citrix.com, jbeulich@suse.com, sasha.levin@oracle.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hey,

I applied all your comments..
> >+The `struct xen_xsplice_status` structure contains an status of payload which includes:
> >+
> >+ * `status` - whether it has been:
> >+   * *XSPLICE_STATUS_LOADED* (1) has been loaded.
> >+   * *XSPLICE_STATUS_CHECKED*  (2) the ELF payload safety checks passed.
> 
> The ELF safety checks are done during load. At this stage we don't have any
> checks yet so I'm not sure what will go here.
> 

The one thing that I am not too crazy about is that the upload
operation takes a long time. As in, we allocate memory, parse it,
then load it, free some memory ,etc.

I am thinking that perhaps of doing that synchronously we schedule
an tasklet that will do that. And hence an payload will move from
LOADED (or UPLOADED?) to CHECKED from a tasklet?

That can solve also the problem of somebody (ahem) having 'sync_console
com1=9600 loglvl=all' and with us parsing - it taking way too long.

Let me see what is involved in this.